feat(editor): Recommend and pre-select auth type with overrides #5684
Conversation
…when creating new credentials
|
Great PR! Please pay attention to the following items before merging: Files matching
Files matching
Make sure to check off this list before asking for review. |
Codecov ReportPatch and project coverage have no change.
Additional details and impacted files@@ Coverage Diff @@
## master #5684 +/- ##
=======================================
Coverage 10.25% 10.25%
=======================================
Files 2200 2200
Lines 84651 84651
Branches 16679 16679
=======================================
Hits 8684 8684
Misses 75481 75481
Partials 486 486 Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report in Codecov by Sentry. |
n8n-assistant
bot
added
n8n team
| field.options.map((option) => { | ||
| // Check if credential type associated with this auth option has overwritten properties | ||
| let hasOverrides = false; | ||
| const cred = getNodeCredentialForSelectedAuthType(nodeType, option.value); |
There was a problem hiding this comment.
Should we only set the overridden credential as default only in n8n cloud? Se the comment from the ticket below.
For cloud, the OAuth auth type should always be pre-selected if it's overwritten (pre-filled)
There was a problem hiding this comment.
Nice catch, looks like it was a misunderstanding. Updated in latest commit.
n8n-assistant
bot
added
the
Upcoming Release
|
Got released with |
|
Got released with |
…io#5684) * feat(editor): Recommend auth type with overrides and pre-select them when creating new credentials * ⚡ Only auto-selecting credentials on cloud
No description provided.