Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(core): Improve SAML connection test #5680

Merged
merged 3 commits into from
Mar 13, 2023
Merged

feat(core): Improve SAML connection test #5680

merged 3 commits into from
Mar 13, 2023

Conversation

flipswitchingmonkey
Copy link
Contributor

@flipswitchingmonkey flipswitchingmonkey commented Mar 13, 2023 •
edited
Loading

No description provided.

@flipswitchingmonkey flipswitchingmonkey marked this pull request as ready for review March 13, 2023 12:52
@github-actions
Copy link
Contributor

Great PR! Please pay attention to the following items before merging:

Files matching packages/**:

  • If fixing bug, added test to cover scenario.
  • If addressing forum or Github issue, added link to description.

Files matching packages/**/*.ts:

  • Added unit tests to cover new or updated functionality.

Make sure to check off this list before asking for review.

@n8n-assistant n8n-assistant bot added core Enhancement outside /nodes-base and /editor-ui n8n team Authored by the n8n team labels Mar 13, 2023
netroy
netroy requested changes Mar 13, 2023
View reviewed changes
packages/cli/src/sso/saml/types/requests.ts Outdated Show resolved Hide resolved
packages/cli/src/sso/saml/routes/saml.controller.ee.ts Outdated Show resolved Hide resolved
@codecov
Copy link

codecov bot commented Mar 13, 2023

Codecov Report

Patch coverage: 14.28% and no project coverage change.

Comparison is base (d253aa3) 10.25% compared to head (6b19ebd) 10.25%.

Additional details and impacted files 
@@           Coverage Diff           @@
##           master    #5680   +/-   ##
=======================================
  Coverage   10.25%   10.25%           
=======================================
  Files        2200     2200           
  Lines       84647    84651    +4     
  Branches    16680    16679    -1     
=======================================
+ Hits         8681     8684    +3     
- Misses      75480    75481    +1     
  Partials      486      486
Impacted Files Coverage Δ
...ages/cli/src/sso/saml/routes/saml.controller.ee.ts 24.13% <11.76%> (+3.44%) ⬆️
...i/src/sso/saml/middleware/samlEnabledMiddleware.ts 30.76% <25.00%> (-2.57%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@flipswitchingmonkey flipswitchingmonkey merged commit ef07528 into master Mar 13, 2023
@flipswitchingmonkey flipswitchingmonkey deleted the pay-167-have-one-endpoint-that-allows-testing branch March 13, 2023 18:47
@n8n-assistant n8n-assistant bot added the Upcoming Release Will be part of the upcoming release label Mar 13, 2023
@janober
Copy link
Member

janober commented Mar 16, 2023

Got released with [email protected]

@janober janober removed the Upcoming Release Will be part of the upcoming release label Mar 16, 2023
sunilrr pushed a commit to fl-g6/qp-n8n that referenced this pull request Apr 24, 2023
@flipswitchingmonkey @sunilrr
feat(core): Improve SAML connection test (n8n-io#5680)
bbeb37a 
* improve saml test

* cleanup

* remove unused SamlConfiguration types
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@netroy netroy netroy approved these changes

Assignees
No one assigned
Labels
core Enhancement outside /nodes-base and /editor-ui n8n team Authored by the n8n team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@flipswitchingmonkey @janober @netroy