Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(editor): Add user activation survey #5677

Merged
merged 40 commits into from
Apr 11, 2023
Merged

feat(editor): Add user activation survey #5677

merged 40 commits into from
Apr 11, 2023

Conversation

RicardoE105
Copy link
Contributor

@RicardoE105 RicardoE105 commented Mar 13, 2023 •
edited
Loading

Context in AD0-415

@github-actions
Copy link
Contributor

github-actions bot commented Mar 13, 2023 •
edited by RicardoE105
Loading

Great PR! Please pay attention to the following items before merging:

Files matching packages/**:

  • If fixing bug, added test to cover scenario.
  • If addressing forum or Github issue, added link to description.

Files matching packages/**/*.ts:

  • Added unit tests to cover new or updated functionality.

Files matching **/*.vue:

  • Used composition API for all new components.
  • Added component or unit tests to cover functionality.

Files matching packages/editor-ui/**/*.vue:

  • Added E2E if adding new features.
  • Used design system tokens (colors, spacings...) where possible.

Files matching cypress/e2e/**:

  • Avoided chaining commands more than two or three times (to avoid flakiness because only last one will be retried).
  • Spoofed endpoints that are not critical for the test (to avoid flakiness).
  • Picked most efficient path to start the test (for example skipped account setup and starting at /workflow/new for a canvas test).
  • Avoided adding waits on time (use request intercepts instead).
  • Ensured each spec does not depend on any another spec to pass.

Make sure to check off this list before asking for review.

@RicardoE105 RicardoE105 changed the title ⚡ Add user activation survey feat(editor): Add user activation survey Mar 13, 2023
@n8n-assistant n8n-assistant bot added core Enhancement outside /nodes-base and /editor-ui n8n team Authored by the n8n team ui Enhancement in /editor-ui or /design-system labels Mar 13, 2023
@codecov
Copy link

codecov bot commented Mar 13, 2023 •
edited
Loading

Codecov Report

Patch coverage: 44.03% and project coverage change: +0.02 🎉

Comparison is base (3fdc441) 17.55% compared to head (12244a5) 17.57%.

Additional details and impacted files 
@@            Coverage Diff             @@
##           master    #5677      +/-   ##
==========================================
+ Coverage   17.55%   17.57%   +0.02%     
==========================================
  Files        2498     2498              
  Lines      114353   114447      +94     
  Branches    17866    17874       +8     
==========================================
+ Hits        20074    20116      +42     
- Misses      93687    93737      +50     
- Partials      592      594       +2
Impacted Files Coverage Δ
packages/cli/src/Server.ts 0.00% <ø> (ø)
...ges/cli/src/UserManagement/UserManagementHelper.ts 78.94% <ø> (ø)
packages/cli/src/config/schema.ts 37.50% <ø> (ø)
packages/cli/src/executions/executions.service.ts 0.00% <ø> (ø)
packages/cli/src/user/user.service.ts 54.54% <0.00%> (-20.46%) ⬇️
packages/editor-ui/src/main.ts 0.00% <0.00%> (ø)
packages/workflow/src/Interfaces.ts 50.00% <ø> (ø)
packages/editor-ui/src/api/users.ts 27.33% <15.38%> (-0.93%) ⬇️
packages/cli/src/controllers/me.controller.ts 89.77% <25.00%> (-6.53%) ⬇️
packages/editor-ui/src/stores/users.ts 42.85% <35.48%> (-0.96%) ⬇️
... and 9 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@RicardoE105
Copy link
Contributor Author

@madgbec can you please elaborate?

@RicardoE105 RicardoE105 marked this pull request as ready for review March 16, 2023 02:14
@RicardoE105 RicardoE105 force-pushed the ado-415-p0-ask-activated-users-for-their-biggest branch from 2fb1252 to 6c8b34b Compare April 4, 2023 03:42
krynble
krynble suggested changes Apr 4, 2023
View reviewed changes
Copy link
Contributor

@krynble krynble left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd ask you to centralise all actions that update the user settings in the user.service.ts and perhaps, to prevent misuse, read data from db first, merge incoming settings and then save, wdyt? Simply because if a user is logged in on multiple devices or this might cause override when we add more settings in the future.

packages/cli/src/UserManagement/UserManagementHelper.ts Outdated Show resolved Hide resolved
packages/cli/src/WorkflowHelpers.ts Outdated Show resolved Hide resolved
packages/cli/src/controllers/me.controller.ts Outdated Show resolved Hide resolved
packages/cli/src/events/WorkflowStatistics.ts Outdated Show resolved Hide resolved
@RicardoE105 RicardoE105 requested a review from krynble April 10, 2023 23:09
krynble
krynble approved these changes Apr 11, 2023
View reviewed changes
Copy link
Contributor

@krynble krynble left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

BE code looks great. Thanks!

@RicardoE105 RicardoE105 merged commit 725393d into master Apr 11, 2023
@RicardoE105 RicardoE105 deleted the ado-415-p0-ask-activated-users-for-their-biggest branch April 11, 2023 16:43
MiloradFilipovic added a commit that referenced this pull request Apr 13, 2023
@MiloradFilipovic
Merge branch 'master' into feature/resource-mapping-component
8576dcc 
* master: (62 commits)
  fix(editor): Redirect to home page after saving data on SAML onboarding page (no-changelog) (#5961)
  feat: Replace Vue.extend with defineComponent in design system (no-changelog) (#5918)
  feat(MySQL Node): Overhaul
  fix(OpenAI Node): Update models to only show those supported (#5805)
  ci: Add test for wait node (no-changelog) (#5414)
  fix(Github Trigger Node): Remove content_reference event (#5830)
  ci: Validate load options methods in nodes-base (no-changelog) (#5862)
  ci: Use `--chown=node:node` in COPY commands in the custom docker image (no-changelog) (#5913)
  🚀 Release 0.224.0 (#5957)
  fix(NocoDB Node): Fix for updating or deleting rows with not default primary keys
  fix(HTTP Request Node): Show detailed error message in the UI again (#5959)
  ci: Prevent skipping of E2E fail job (no-changelog) (#5958)
  ci: Fix E2E tests on master (no-changelog) (#5960)
  refactor(core): Use injectable classes for db repositories (part-1) (no-changelog) (#5953)
  fix(core): Validate customData keys and values (#5920) (no-changelog)
  feat(editor): Add user activation survey (#5677)
  fix(editor): Update vite legacy-plugin browser target (no-changelog) (#5952)
  docs: Fix typo in AWS S3 and S3 nodes for parent folder key (#5933)
  fix(core): Update xml2js to address CVE-2023-0842 (#5948)
  fix(Code Node): Update vm2 to address CVE-2023-29017 (#5947)
  ...

# Conflicts:
#	packages/workflow/src/Interfaces.ts
MiloradFilipovic added a commit that referenced this pull request Apr 13, 2023
@MiloradFilipovic
Merge branch 'feature/resource-mapping-component' into NODE-399-resou…
1d808a9 
…rce-mapper-ui

* feature/resource-mapping-component: (62 commits)
  fix(editor): Redirect to home page after saving data on SAML onboarding page (no-changelog) (#5961)
  feat: Replace Vue.extend with defineComponent in design system (no-changelog) (#5918)
  feat(MySQL Node): Overhaul
  fix(OpenAI Node): Update models to only show those supported (#5805)
  ci: Add test for wait node (no-changelog) (#5414)
  fix(Github Trigger Node): Remove content_reference event (#5830)
  ci: Validate load options methods in nodes-base (no-changelog) (#5862)
  ci: Use `--chown=node:node` in COPY commands in the custom docker image (no-changelog) (#5913)
  🚀 Release 0.224.0 (#5957)
  fix(NocoDB Node): Fix for updating or deleting rows with not default primary keys
  fix(HTTP Request Node): Show detailed error message in the UI again (#5959)
  ci: Prevent skipping of E2E fail job (no-changelog) (#5958)
  ci: Fix E2E tests on master (no-changelog) (#5960)
  refactor(core): Use injectable classes for db repositories (part-1) (no-changelog) (#5953)
  fix(core): Validate customData keys and values (#5920) (no-changelog)
  feat(editor): Add user activation survey (#5677)
  fix(editor): Update vite legacy-plugin browser target (no-changelog) (#5952)
  docs: Fix typo in AWS S3 and S3 nodes for parent folder key (#5933)
  fix(core): Update xml2js to address CVE-2023-0842 (#5948)
  fix(Code Node): Update vm2 to address CVE-2023-29017 (#5947)
  ...

# Conflicts:
#	packages/workflow/src/Interfaces.ts
@janober
Copy link
Member

janober commented Apr 19, 2023

Got released with [email protected]

sunilrr pushed a commit to fl-g6/qp-n8n that referenced this pull request Apr 24, 2023
@RicardoE105 @sunilrr
feat(editor): Add user activation survey (n8n-io#5677)
6628d71 
* ⚡ Add user activation survey

* Fix typo

* Avoid showing the modal when there is a modal view

* Allow to redirect to specific execution

* Improve structure

* Handle errors when sharing feedback

* update withFeatureFlag function

* Fix linting issue

* Set user activation flag on workflowExecutionCompleted event

* Revert update user settings functionality

* Remove unnecessary changes

* fix linting issue

* account for new functionality in tests

* Small improvements

* keep once instace of the model open between tabs

* Add sorting to GET /executions

* type parameters for GET /executions


a

* Add constant for local store key

* Add execution mode filtering

* fix linting issue

* Do not override settings when setting isOnboarded true

* Add update user settings endpoint

* improvements

* revert changes to /GET executions

* Fix typo

* Add userActivated flag to user store

* Add E2E test

* Fix linting issue

* Update pnpm-lock

* Revert unnecessary change

* Centralize user's settings update

* Remove unused ref in userActivationSurvey modal

* Use aliased imports

* Use createEventBus function in component

* Fix tests
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@OlegIvaniv OlegIvaniv OlegIvaniv left review comments

@krynble krynble krynble approved these changes

Assignees
No one assigned
Labels
core Enhancement outside /nodes-base and /editor-ui n8n team Authored by the n8n team Released ui Enhancement in /editor-ui or /design-system
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@RicardoE105 @janober @krynble @OlegIvaniv