Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(Split In Batches Node): Make it easy to combine processed data #5655

Merged
merged 1 commit into from
Mar 14, 2023

Conversation

janober
Copy link
Member

@janober janober commented Mar 9, 2023

First try to make SplitInBatches node easier to use by adding output which outputs the combined data once all data got processed.

Should be a non breaking change so no new version got created for it.

Screenshot from 2023-03-09 13-45-01

Github issue / Community forum post (link here to close automatically):

@github-actions
Copy link
Contributor

github-actions bot commented Mar 9, 2023

Great PR! Please pay attention to the following items before merging:

Files matching packages/**:

  • If fixing bug, added test to cover scenario.
  • If addressing forum or Github issue, added link to description.

Files matching packages/**/*.ts:

  • Added unit tests to cover new or updated functionality.

Files matching packages/nodes-base/nodes/**:

  • Added workflow tests for nodes if possible.

Make sure to check off this list before asking for review.

@n8n-assistant n8n-assistant bot added n8n team Authored by the n8n team node/improvement New feature or request labels Mar 9, 2023
@janober janober changed the title feat(SplitInBatches Node): Make it easy to combine processed data feat(Split In Batches Node): Make it easy to combine processed data Mar 10, 2023
@janober janober marked this pull request as ready for review March 14, 2023 09:14
Copy link
Contributor

@maspio maspio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

@janober janober merged commit 2f7639e into master Mar 14, 2023
@janober janober deleted the splitInBatches-with-combine branch March 14, 2023 17:42
@janober janober added the Upcoming Release Will be part of the upcoming release label Mar 14, 2023
@janober
Copy link
Member Author

janober commented Mar 16, 2023

Got released with [email protected]

@janober janober removed the Upcoming Release Will be part of the upcoming release label Mar 16, 2023
sunilrr pushed a commit to fl-g6/qp-n8n that referenced this pull request Apr 24, 2023
…8n-io#5655)

feat(SplitInBatches Node): Make it easy to combine processed data
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
n8n team Authored by the n8n team node/improvement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants