Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ERPNext cloud hosted domain needs to be changed #5632

Closed
monolithonadmin opened this issue Mar 6, 2023 · 3 comments
Closed

ERPNext cloud hosted domain needs to be changed #5632

monolithonadmin opened this issue Mar 6, 2023 · 3 comments
Labels
in linear Issue or PR has been created in Linear for internal review Released

Comments

@monolithonadmin
Copy link

Upon examining the code for n8n, I have observed that the hosted instance uses the erpnext.com domain. The code can be found at

https://github.com/n8n-io/n8n/blob/bb4db58819b6624de98249125f1ffb8c491d21ef/packages/nodes-base/nodes/ERPNext/GenericFunctions.ts.

environment === 'cloudHosted' ? https://${subdomain}.erpnext.com : domain;

However, since the launch of Frappecloud, they have offered subdomains under frappe.cloud.

@Joffcom
Copy link
Member

Joffcom commented Mar 7, 2023

Hey @monolithonadmin,

That is a good spot, We would still need to support the erpnext.com domain as well so the custom option should work around this but we should maybe have an option to select if it is frappecloud or not.

I have created NODE-364 as the internal ticket for this one.

@Joffcom Joffcom added the in linear Issue or PR has been created in Linear for internal review label Mar 7, 2023
@Joffcom
Copy link
Member

Joffcom commented May 22, 2023

Hey @monolithonadmin,

I have just merged the change for this one so it should be available in the next release (0.230.0) I am going to mark this one as closed for now 🙌🏻

@Joffcom Joffcom closed this as completed May 22, 2023
@janober
Copy link
Member

janober commented May 25, 2023

Fix got released with [email protected]

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
in linear Issue or PR has been created in Linear for internal review Released
Projects
None yet
Development

No branches or pull requests

3 participants