-
Notifications
You must be signed in to change notification settings - Fork 8.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(core): Add SAML XML validation #5600
Merged
flipswitchingmonkey
merged 18 commits into
master
from
pay-267-validate-saml-xml-against-xsd-schema
Mar 6, 2023
Merged
feat(core): Add SAML XML validation #5600
flipswitchingmonkey
merged 18 commits into
master
from
pay-267-validate-saml-xml-against-xsd-schema
Mar 6, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # packages/cli/src/sso/saml/middleware/samlEnabledMiddleware.ts # packages/cli/src/sso/saml/samlHelpers.ts
…e-internal-api-endpoints-to-set-up
n8n-assistant
bot
added
core
Enhancement outside /nodes-base and /editor-ui
n8n team
Authored by the n8n team
labels
Mar 2, 2023
Base automatically changed from
pay-153-create-internal-api-endpoints-to-set-up
to
master
March 3, 2023 09:19
# Conflicts: # packages/cli/src/sso/saml/routes/saml.controller.protected.ee.ts # packages/cli/src/sso/saml/saml.service.ee.ts # packages/cli/src/sso/saml/types/samlPreferences.ts # packages/cli/src/sso/ssoHelpers.ts
RicardoE105
approved these changes
Mar 4, 2023
flipswitchingmonkey
deleted the
pay-267-validate-saml-xml-against-xsd-schema
branch
March 6, 2023 08:44
Got released with |
sunilrr
pushed a commit
to fl-g6/qp-n8n
that referenced
this pull request
Apr 24, 2023
* consolidate SSO settings * update saml settings * fix type error * limit user changes when saml is enabled * add test * add toggle endpoint and fetch metadata * rename enabled param * add handling of POST saml login request * add config test endpoint * adds saml XML validation * add comment * protect test endpoint * improve ignoreSSL and some cleanup * fix wrong schema used * remove console.log
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Github issue / Community forum post (link here to close automatically):