Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(core): Add SAML XML validation #5600

Merged

Conversation

flipswitchingmonkey
Copy link
Contributor

Github issue / Community forum post (link here to close automatically):

@flipswitchingmonkey flipswitchingmonkey marked this pull request as ready for review March 2, 2023 15:40
@n8n-assistant n8n-assistant bot added core Enhancement outside /nodes-base and /editor-ui n8n team Authored by the n8n team labels Mar 2, 2023
@flipswitchingmonkey flipswitchingmonkey marked this pull request as draft March 3, 2023 09:17
Base automatically changed from pay-153-create-internal-api-endpoints-to-set-up to master March 3, 2023 09:19
# Conflicts:
#	packages/cli/src/sso/saml/routes/saml.controller.protected.ee.ts
#	packages/cli/src/sso/saml/saml.service.ee.ts
#	packages/cli/src/sso/saml/types/samlPreferences.ts
#	packages/cli/src/sso/ssoHelpers.ts
@flipswitchingmonkey flipswitchingmonkey marked this pull request as ready for review March 3, 2023 10:08
@flipswitchingmonkey flipswitchingmonkey merged commit ca66ec8 into master Mar 6, 2023
@flipswitchingmonkey flipswitchingmonkey deleted the pay-267-validate-saml-xml-against-xsd-schema branch March 6, 2023 08:44
@n8n-assistant n8n-assistant bot added the Upcoming Release Will be part of the upcoming release label Mar 6, 2023
@janober
Copy link
Member

janober commented Mar 10, 2023

Got released with [email protected]

@janober janober removed the Upcoming Release Will be part of the upcoming release label Mar 10, 2023
sunilrr pushed a commit to fl-g6/qp-n8n that referenced this pull request Apr 24, 2023
* consolidate SSO settings

* update saml settings

* fix type error

* limit user changes when saml is enabled

* add test

* add toggle endpoint and fetch metadata

* rename enabled param

* add handling of POST saml login request

* add config test endpoint

* adds saml XML validation

* add comment

* protect test endpoint

* improve ignoreSSL and some cleanup

* fix wrong schema used

* remove console.log
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
core Enhancement outside /nodes-base and /editor-ui n8n team Authored by the n8n team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants