Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Execution preview is not loaded when system run in iframe #5584

Closed
ponix-net opened this issue Feb 28, 2023 · 3 comments
Closed

Execution preview is not loaded when system run in iframe #5584

ponix-net opened this issue Feb 28, 2023 · 3 comments
Labels
in linear Issue or PR has been created in Linear for internal review Released

Comments

@ponix-net
Copy link

Describe the bug
When running system in iframe of another web page the execution preview is not loaded in executions view.

To Reproduce
Steps to reproduce the behavior:

  1. Run n8n server.
  2. Create web page with iframe with source pointing to executions view (like 'http://localhost:5678/workflow/1/executions/23').
  3. Loader is displayed.

Expected behavior
Execution preview is displayed.

Environment (please complete the following information):

  • OS: Ubuntu Linux 22.04
  • n8n Version 0.217.2
  • Node.js Version 18.14.2
  • Operation mode own

Probable cause and proposed solution
Execution preview is run also in iframe and sends message to top window to say that it was loaded (n8nReady). It should send message to parent instead of top window.
I've changed lines 3871-3872 in file NodeView.vue to:

3871:  if (window.parent) {
3872:      window.parent.postMessage(

and it worked as expected, execution preview was loaded.

@Joffcom
Copy link
Member

Joffcom commented Mar 1, 2023

Hey @ponix-net,

Thanks for reporting this one, I have created an internal ticket for this which we will be tracking as N8N-6216.

@Joffcom Joffcom added the in linear Issue or PR has been created in Linear for internal review label Mar 1, 2023
@janober
Copy link
Member

janober commented Apr 19, 2023

Fix got released with [email protected]

@Joffcom
Copy link
Member

Joffcom commented Apr 19, 2023

Hey @ponix-net,

This should now be resolved, I am going to mark this one as closed. If you still this issue let me know and we can open the issue again.

@Joffcom Joffcom closed this as completed Apr 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
in linear Issue or PR has been created in Linear for internal review Released
Projects
None yet
Development

No branches or pull requests

3 participants