-
Notifications
You must be signed in to change notification settings - Fork 7.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(editor): Add missing documentation to autocomplete items for inline code editor #5560
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…erent items with same labels.
* master: (37 commits) feat: Migrate packages from lodash to lodash-es (no-changelog) (#5538) fix(editor): Apply correct IRunExecutionData to finished workflow (#5552) feat: Check new n8n version at start (no-changelog) (#5542) fix(editor): Remove 'crashed' status from filter (#5524) fix(editor): Fix an issue with zoom and canvas nodes connections (#5548) fix(Google Calendar Node): Fix incorrect labels for start and end times when getting all events (#5529) fix: fix typo in error messages when a property does not exist (#4310) feat: Hide sensible value in Auth Header Credentials and Auth Query Credentials (#5534) refactor(WhatsApp Node): Avoid using BinaryDataManager directly from n8n-core (#5544) fix(Discord Node): Fix wrong error message being displayed (#5547) fix(core): Do not remove empty output connections arrays in PurgeInvalidWorkflowConnections migration (#5546) ci: Check PR title on all branches, except release branches (no-changelog) (#5545) fix(core): Fix execution status filters (#5533) refactor(core): Use an IoC container to manage singleton classes [Part-1] (no-changelog) (#5509) ci: Merge back released tag to master as Jan (no-changelog) (#5540) fix(Discourse Node): Fix issue with credential test not working (#5520) ci: Release process improvements (no-changelog) (#5535) feat: Add Required path name mapping to multiple nodes (#5369) fix(Compare Datasets Node): UI tweaks and fixes feat: Add new event hooks (#5530) ...
n8n-assistant
bot
added
core
Enhancement outside /nodes-base and /editor-ui
n8n team
Authored by the n8n team
ui
Enhancement in /editor-ui or /design-system
labels
Feb 23, 2023
alexgrozav
approved these changes
Feb 24, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome work! So much better UX. Hope to have these for the Code node as well sometime. :D
n8n-assistant
bot
added
the
Upcoming Release
Will be part of the upcoming release
label
Feb 28, 2023
Got released with |
sunilrr
pushed a commit
to fl-g6/qp-n8n
that referenced
this pull request
Apr 24, 2023
…ine code editor (n8n-io#5560) * ⚡ Added documentation for extension functions with arguments * ⚡ Adding custom autocomplete item types. This enables us to show different items with same labels. * 📚 Adding missing info for extensions autocomplete items * ⚡ Added Luxon autocomplete docs * 💡 Completing Luxon static methods autocomplete documentation * ⚡ Refactoring Luxon autocomplete logic * ⚡ Handling the case when autocomplete item doesn't have defined inline documentation * ⚡ Added correct doc info to Luxon instance properties * ✨ Added missing documentation and notice footer for autocomplete popup. * 👕 Fixing lint error * ✔️ Removing `Object.hasOwn` function, since it's not supported in node v14
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Github issue / Community forum post (link here to close automatically):