fix: Fixes an issue when saving an active workflow without triggers would cause n8n to be stuck #5513
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
netroy
approved these changes
Feb 20, 2023
n8n-assistant
bot
added
the
Upcoming Release
|
Got released with |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes an issue that could be found if a user has an active workflow, then removes all triggers and tries to save it.
n8n would update the workflow's version ID and prevent the user from further changing the workflow, forcing a refresh.
Now when n8n fails to activate the workflow, we still tell the users that this happened but revert versionId, allowing the user to make further changes and fix the error.
Github issue / Community forum post (link here to close automatically):