Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(editor): Adjust HTML editor component for use in params #5285

Merged
merged 5 commits into from
Feb 2, 2023
Merged

feat(editor): Adjust HTML editor component for use in params #5285

merged 5 commits into from
Feb 2, 2023

Conversation

ivov
Copy link
Contributor

@ivov ivov commented Jan 30, 2023

image

@n8n-assistant n8n-assistant bot added n8n team Authored by the n8n team node/improvement New feature or request ui Enhancement in /editor-ui or /design-system labels Jan 30, 2023
OlegIvaniv
OlegIvaniv previously approved these changes Feb 2, 2023
View reviewed changes
Copy link
Contributor

@OlegIvaniv OlegIvaniv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me! There's just one small nitpick but it shouldn't prevent the merged

packages/editor-ui/src/components/ParameterOptions.vue Outdated Show resolved Hide resolved
@ivov
Copy link
Contributor Author

ivov commented Feb 2, 2023

Thanks for reviewing! Disregarding e2e 4-node-creator.cy.ts as unrelated.

@ivov ivov merged commit 8b09e98 into master Feb 2, 2023
@ivov ivov deleted the html-editor-component branch February 2, 2023 13:00
@n8n-assistant n8n-assistant bot added the Upcoming Release Will be part of the upcoming release label Feb 2, 2023
@janober
Copy link
Member

janober commented Feb 3, 2023

Got released with [email protected]

@janober janober removed the Upcoming Release Will be part of the upcoming release label Feb 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@maspio maspio maspio left review comments

@OlegIvaniv OlegIvaniv OlegIvaniv approved these changes

Assignees
No one assigned
Labels
n8n team Authored by the n8n team node/improvement New feature or request ui Enhancement in /editor-ui or /design-system
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@ivov @janober @OlegIvaniv @maspio