Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(HTTP Request Node): Ignore empty body for auto detect json #5215

Merged
merged 2 commits into from
Feb 16, 2023
Merged

fix(HTTP Request Node): Ignore empty body for auto detect json #5215

merged 2 commits into from
Feb 16, 2023

Conversation

feelgood-interface
Copy link
Contributor

Github issue / Community forum post (link here to close automatically):
#5214

@feelgood-interface feelgood-interface changed the title #5214: ignore empty body for auto detect json fix(HTTP Request node): ignore empty body for auto detect json Jan 21, 2023
@feelgood-interface feelgood-interface changed the title fix(HTTP Request node): ignore empty body for auto detect json fix(HTTP Request Node): ignore empty body for auto detect json Jan 21, 2023
@feelgood-interface feelgood-interface changed the title fix(HTTP Request Node): ignore empty body for auto detect json fix(HTTP Request Node): Ignore empty body for auto detect json Jan 21, 2023
@n8n-assistant n8n-assistant bot added community Authored by a community member node/improvement New feature or request labels Jan 21, 2023
Copy link
Member

@Joffcom Joffcom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested and works well.

@Joffcom
Copy link
Member

Joffcom commented Feb 16, 2023

Hey @feelgood-interface,

Thanks for the PR 🙌🏻 , We made a bit of a change so that there is still an error to let you know the JSON is invalid and if you want to ignore the error you can set Options > Response > Never Error and that will now correctly allow the workflow to continue.

Thanks for taking the time to put this one in.

@Joffcom Joffcom merged commit af70337 into n8n-io:master Feb 16, 2023
@n8n-assistant n8n-assistant bot added the Upcoming Release Will be part of the upcoming release label Feb 16, 2023
@janober
Copy link
Member

janober commented Feb 16, 2023

Got released with [email protected]

@janober janober removed the Upcoming Release Will be part of the upcoming release label Feb 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
community Authored by a community member node/improvement New feature or request skip-e2e
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants