feat(core): Add execution runData recovery and status field #5112
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
n8n-assistant
bot
added
core
# Conflicts: # packages/cli/src/eventbus/MessageEventBus/MessageEventBus.ts # packages/cli/src/eventbus/MessageEventBusWriter/MessageEventBusLogWriter.ts # packages/editor-ui/src/components/ExecutionsList.vue # packages/editor-ui/src/mixins/restApi.ts # packages/editor-ui/src/plugins/i18n/locales/en.json
# Conflicts: # packages/cli/src/eventbus/MessageEventBus/MessageEventBus.ts
flipswitchingmonkey
changed the title
# Conflicts: # packages/cli/src/Server.ts # packages/cli/src/databases/migrations/mysqldb/index.ts # packages/cli/src/databases/migrations/postgresdb/index.ts # packages/cli/src/databases/migrations/sqlite/index.ts
# Conflicts: # packages/cli/src/WorkflowExecuteAdditionalData.ts # packages/cli/src/WorkflowRunner.ts # packages/cli/src/commands/executeBatch.ts # packages/cli/src/commands/start.ts # packages/cli/src/commands/worker.ts
krynble
reviewed
Feb 16, 2023
| @@ -59,32 +66,37 @@ export class ActiveExecutions { | |||
| const execution = ResponseHelper.flattenExecutionData(fullExecutionData); | |||
|
|
|||
| const executionResult = await Db.collections.Execution.save(execution as IExecutionFlattedDb); | |||
| // TODO: what is going on here? | |||
There was a problem hiding this comment.
This is probably legacy from when we supported MongoDB where IDs where instances of ObjectID
There was a problem hiding this comment.
So.... should we keep it in?
There was a problem hiding this comment.
I guess we could remove this, since this is in the codebase for over 2 years.
krynble
previously approved these changes
Feb 17, 2023
krynble
approved these changes
Feb 17, 2023
n8n-assistant
bot
added
the
Upcoming Release
|
Got released with |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR will add a
statusfield to the execution table and sets the status at appropriate points during the executions lifecycle.It also leverages the event logging journal to attempt to recover execution run data in the case of a crashed execution (e.g. through out of memory issues), to pinpoint the node that caused the crash.
Also updates the frontend accordingly to read the status field.
#2195