Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

perf: Lazy-load queue-mode and analytics dependencies #5061

Merged
merged 4 commits into from
Jan 2, 2023

Conversation

netroy
Copy link
Member

@netroy netroy commented Dec 29, 2022

Startup peak:
image

After GC settles down a bit:
image

PS: The actual difference in the memory usage is not a lot. but, in general, it's a good idea to avoid loading node modules that we are not going to be using.

@n8n-assistant n8n-assistant bot added core Enhancement outside /nodes-base and /editor-ui n8n team Authored by the n8n team labels Dec 29, 2022
@netroy netroy requested a review from ivov January 2, 2023 10:55
Copy link
Contributor

@krynble krynble left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, tested with queue mode and telemetry enabled, seems fine.

@netroy netroy merged commit b828cb3 into master Jan 2, 2023
@netroy netroy deleted the lazy-load-dependencies-part-2 branch January 2, 2023 11:14
@n8n-assistant n8n-assistant bot added the Upcoming Release Will be part of the upcoming release label Jan 2, 2023
@janober
Copy link
Member

janober commented Jan 5, 2023

Got released with [email protected]

@janober janober removed the Upcoming Release Will be part of the upcoming release label Jan 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
core Enhancement outside /nodes-base and /editor-ui n8n team Authored by the n8n team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants