Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add workflow sharing telemetry #4906

Merged
merged 4 commits into from
Dec 15, 2022

Conversation

alexgrozav
Copy link
Member

No description provided.

@n8n-assistant n8n-assistant bot added n8n team Authored by the n8n team ui Enhancement in /editor-ui or /design-system labels Dec 13, 2022
@@ -206,6 +206,12 @@ export default mixins(showMessage, restApi).extend({
name: WORKFLOW_SHARE_MODAL_KEY,
data: { id: this.data.id },
});

this.$telemetry.track('User opened sharing modale', {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
this.$telemetry.track('User opened sharing modale', {
this.$telemetry.track('User opened sharing modal', {

Copy link
Member Author

@alexgrozav alexgrozav Dec 14, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed in both places

@alexgrozav alexgrozav merged commit ac066fc into master Dec 15, 2022
@alexgrozav alexgrozav deleted the pay-25-add-telemetry-to-workflow-sharing branch December 15, 2022 08:05
@n8n-assistant n8n-assistant bot added the Upcoming Release Will be part of the upcoming release label Dec 15, 2022
@janober
Copy link
Member

janober commented Dec 16, 2022

Got released with [email protected]

@janober janober removed the Upcoming Release Will be part of the upcoming release label Dec 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
n8n team Authored by the n8n team ui Enhancement in /editor-ui or /design-system
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants