Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Fix foreign credentials being shown for new nodes #4622

Merged
merged 3 commits into from
Nov 17, 2022
Merged

fix: Fix foreign credentials being shown for new nodes #4622

merged 3 commits into from
Nov 17, 2022

Conversation

alexgrozav
Copy link
Member

  • Extract usedCredentials into separate store entry

@n8n-assistant n8n-assistant bot added n8n team Authored by the n8n team ui Enhancement in /editor-ui or /design-system labels Nov 16, 2022
MiloradFilipovic
MiloradFilipovic previously approved these changes Nov 17, 2022
View reviewed changes
Copy link
Contributor

@MiloradFilipovic MiloradFilipovic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice. Works as expected.

MiloradFilipovic
MiloradFilipovic approved these changes Nov 17, 2022
View reviewed changes
Copy link
Contributor

@MiloradFilipovic MiloradFilipovic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Re-approving after conflicts are resolved.

@alexgrozav alexgrozav merged commit dea67ca into master Nov 17, 2022
@alexgrozav alexgrozav deleted the n8n-5575-foreign-credentials-are-getting-shown branch November 17, 2022 14:22
@n8n-assistant n8n-assistant bot added the Upcoming Release Will be part of the upcoming release label Nov 17, 2022
@janober
Copy link
Member

janober commented Nov 17, 2022

Got released with [email protected]

@janober janober removed the Upcoming Release Will be part of the upcoming release label Nov 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MiloradFilipovic MiloradFilipovic MiloradFilipovic approved these changes

Assignees
No one assigned
Labels
n8n team Authored by the n8n team ui Enhancement in /editor-ui or /design-system
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@alexgrozav @janober @MiloradFilipovic