Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(editor): limiting columns in table view to prevent unresponsive UI when opening NDV #4480

Merged
merged 8 commits into from
Nov 2, 2022
Merged

fix(editor): limiting columns in table view to prevent unresponsive UI when opening NDV #4480

merged 8 commits into from
Nov 2, 2022

Conversation

cstuncsik
Copy link
Contributor

No description provided.

@linear
Copy link

linear bot commented Oct 31, 2022

N8N-5025

@n8n-assistant n8n-assistant bot added n8n team Authored by the n8n team ui Enhancement in /editor-ui or /design-system labels Oct 31, 2022
@cstuncsik cstuncsik marked this pull request as ready for review November 1, 2022 10:42
mutdmour
mutdmour previously approved these changes Nov 1, 2022
View reviewed changes
Copy link
Contributor

@mutdmour mutdmour left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. minor comment, address if you want

packages/editor-ui/src/components/RunDataTable.vue Outdated Show resolved Hide resolved
@cstuncsik cstuncsik merged commit 41e6489 into master Nov 2, 2022
@cstuncsik cstuncsik deleted the n8n-5025-ui-becomes-unresponsive-when-opening branch November 2, 2022 08:23
@n8n-assistant n8n-assistant bot added the Upcoming Release Will be part of the upcoming release label Nov 2, 2022
@janober
Copy link
Member

janober commented Nov 2, 2022

Got released with [email protected]

@janober janober removed the Upcoming Release Will be part of the upcoming release label Nov 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mutdmour mutdmour mutdmour approved these changes

Assignees
No one assigned
Labels
n8n team Authored by the n8n team ui Enhancement in /editor-ui or /design-system
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@cstuncsik @janober @mutdmour