Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(editor): fix performance issues when opening node or editing code node with a lot of data #4388

Merged
merged 14 commits into from
Oct 20, 2022

Conversation

mutdmour
Copy link
Contributor

No description provided.

@linear
Copy link

linear bot commented Oct 20, 2022

N8N-5080

@n8n-assistant n8n-assistant bot added n8n team Authored by the n8n team ui Enhancement in /editor-ui or /design-system labels Oct 20, 2022
@mutdmour mutdmour changed the title fix(editor): fix performance issues when opening node with a lot of data fix(editor): fix performance issues when opening node or editing code node with a lot of data Oct 20, 2022
Copy link
Contributor

@OlegIvaniv OlegIvaniv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice job, it definitely feels more responsive! I've left a few comments

OlegIvaniv
OlegIvaniv previously approved these changes Oct 20, 2022
@mutdmour mutdmour merged commit 356a42a into master Oct 20, 2022
@mutdmour mutdmour deleted the N8N-5080-ndv-perf-1 branch October 20, 2022 13:45
@n8n-assistant n8n-assistant bot added the Upcoming Release Will be part of the upcoming release label Oct 20, 2022
@janober
Copy link
Member

janober commented Oct 21, 2022

Got released with [email protected]

@janober janober removed the Upcoming Release Will be part of the upcoming release label Oct 21, 2022
valya pushed a commit to valya/n8n that referenced this pull request Nov 8, 2022
… node with a lot of data (n8n-io#4388)

* debounce clicks

* debounce correctly

* debounce resize

* if initialized avoid

* set watcher fixes

* add deboucne for setting values

* increase debounce

* reset workspace for memory issues

* address comment

* decrease debounce time

* decrease debounce time

* clean up

* revert back to trailing

* support dbl
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
n8n team Authored by the n8n team ui Enhancement in /editor-ui or /design-system
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants