Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(core): fix hooks URLs no longer added to index.html #4262

Merged

Conversation

ivov
Copy link
Contributor

@ivov ivov commented Oct 4, 2022

No description provided.

@linear
Copy link

linear bot commented Oct 4, 2022

N8N-4859

Copy link
Member

@netroy netroy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for fixing this.

const compileFile = async (fileName: string) => {
const filePath = pathJoin(editorUiDistDir, fileName);
if (/(index.html)|.*\.(js|css)/.test(filePath) && existsSync(filePath)) {
if (/(index\.html)|.*\.(js|css)/.test(filePath) && existsSync(filePath)) {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🤦

@n8n-assistant n8n-assistant bot added core Enhancement outside /nodes-base and /editor-ui n8n team Authored by the n8n team labels Oct 4, 2022
@netroy netroy merged commit cc2a2e4 into master Oct 4, 2022
@netroy netroy deleted the n8n-4859-fix-hooks-urls-no-longer-added-to-index-html branch October 4, 2022 16:40
@n8n-assistant n8n-assistant bot added the Upcoming Release Will be part of the upcoming release label Oct 4, 2022
@janober
Copy link
Member

janober commented Oct 10, 2022

Got released with [email protected]

@janober janober removed the Upcoming Release Will be part of the upcoming release label Oct 10, 2022
valya pushed a commit to valya/n8n that referenced this pull request Nov 8, 2022
🐛 Fix hooks URLs no longer added to `index.html`
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
core Enhancement outside /nodes-base and /editor-ui n8n team Authored by the n8n team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants