Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(QuickChart Node): Add QuickChart node #3572

Merged
merged 31 commits into from
Mar 17, 2023
Merged

feat(QuickChart Node): Add QuickChart node #3572

merged 31 commits into from
Mar 17, 2023

Conversation

valya
Copy link
Contributor

@valya valya commented Jun 22, 2022

No description provided.

@CLAassistant
Copy link

CLAassistant commented Jun 22, 2022

CLA assistant check
All committers have signed the CLA.

@n8n-assistant n8n-assistant bot added n8n team Authored by the n8n team node/new Creation of an entirely new node labels Jun 22, 2022
@valya valya changed the title [WIP] QuickChart node QuickChart node Jul 4, 2022
@valya valya marked this pull request as ready for review July 4, 2022 10:44
@valya valya requested a review from RicardoE105 July 4, 2022 10:44
@maspio maspio changed the title QuickChart node feat(QuickChart node): Add QuickChart node Feb 10, 2023
@maspio maspio changed the title feat(QuickChart node): Add QuickChart node feat(QuickChart Node): Add QuickChart node Feb 10, 2023
michael-radency
michael-radency previously approved these changes Mar 6, 2023
Copy link
Contributor

@michael-radency michael-radency left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actions
Copy link
Contributor

github-actions bot commented Mar 13, 2023

Great PR! Please pay attention to the following items before merging:

Files matching packages/**:

  • If fixing bug, added test to cover scenario.
  • If addressing forum or Github issue, added link to description.

Files matching packages/**/*.ts:

  • Added unit tests to cover new or updated functionality.

Files matching packages/nodes-base/nodes/**:

  • Added workflow tests for nodes if possible.

Make sure to check off this list before asking for review.

@codecov
Copy link

codecov bot commented Mar 13, 2023

Codecov Report

Patch coverage: 72.72% and project coverage change: -0.01 ⚠️

Comparison is base (7a352ef) 13.26% compared to head (39b8ca2) 13.26%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3572      +/-   ##
==========================================
- Coverage   13.26%   13.26%   -0.01%     
==========================================
  Files        2463     2465       +2     
  Lines      112783   112838      +55     
  Branches    17542    17554      +12     
==========================================
+ Hits        14958    14963       +5     
- Misses      97318    97365      +47     
- Partials      507      510       +3     
Impacted Files Coverage Δ
...ges/nodes-base/nodes/QuickChart/QuickChart.node.ts 70.00% <70.00%> (ø)
packages/nodes-base/nodes/QuickChart/constants.ts 100.00% <100.00%> (ø)

... and 5 files with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@maspio maspio merged commit 233f1fa into master Mar 17, 2023
@maspio maspio deleted the n8n-3871-quickchart branch March 17, 2023 11:50
@n8n-assistant n8n-assistant bot added the Upcoming Release Will be part of the upcoming release label Mar 17, 2023
@janober
Copy link
Member

janober commented Mar 26, 2023

Got released with [email protected]

@janober
Copy link
Member

janober commented Mar 26, 2023

Got released with [email protected]

sunilrr pushed a commit to fl-g6/qp-n8n that referenced this pull request Apr 24, 2023
* ✨ Add basic QuickChart node

* 🏷️ Fix up types

* ❇️ Add Boxplot and Violin

* ❇️ Add point styles

* ❇️ Add horizontal charts

* ⚡ Make possible to provide array of labels via expressions

* ⚡ Improvements

* ⚡ Improvements

* 🎨 fix lint errors

* ⚡️disable chart types we don't want to support in P0

* ⚡️support setting labels manually or using an array

* ⚡️move Horizontal parameter into options

* ⚡️ update "Put Output In Field" param description and hint

* ⚡️ removed font color

* ⚡️fix Device Pixel Ratio

* ⚡️fix Polar Chart not working

* ⚡️Show Fill param only for charts supporting it

* ⚡️Show pointStyle param only for charts supporting it

* ⚡️remove second "Chart Type" option

* ⚡ updated error message, added json data, updated description

* Add codex json file

* ✅ add unit test

* ✅ improve unit test

* ⚡ removed any, added aliases

---------

Co-authored-by: ricardo <[email protected]>
Co-authored-by: Marcus <[email protected]>
Co-authored-by: Michael Kret <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
n8n team Authored by the n8n team node/new Creation of an entirely new node Released Upcoming Release Will be part of the upcoming release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants