Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support getting Wise statements as JSON, CSV or PDF - N8N-3847 #3468

Merged
merged 1 commit into from
Jun 13, 2022

Conversation

mocanew
Copy link
Contributor

@mocanew mocanew commented Jun 4, 2022

Wise exports statements in JSON, CSV and PDF formats, but currently, n8n supports only JSON.
This may be more of a feature request, but I thought of opening a PR since I already "fixed" it for internal use.

While modifying getStatements I noticed transfer: get used a helper function that set {encoding: null} while using the new httpRequest helper, so I updated it too.

Tested:

  • getStatement with output types JSON, CSV and PDF
  • transfer: get with output types JSON and PDF

@CLAassistant
Copy link

CLAassistant commented Jun 4, 2022

CLA assistant check
All committers have signed the CLA.

@n8n-assistant n8n-assistant bot added community Authored by a community member node/improvement New feature or request labels Jun 4, 2022
@RicardoE105 RicardoE105 changed the title Support getting Wise statements as JSON, CSV or PDF Support getting Wise statements as JSON, CSV or PDF - N8N-3847 Jun 13, 2022
@RicardoE105
Copy link
Contributor

@rontav, thanks very much for your contribution. I tested it, and it works perfectly. We will let you know when it's released.

@janober janober merged commit 51663c1 into n8n-io:master Jun 13, 2022
@janober
Copy link
Member

janober commented Jun 13, 2022

Thanks a lot. Got merged. Will be released with the next version.

@janober janober added the Upcoming Release Will be part of the upcoming release label Jun 13, 2022
@janober
Copy link
Member

janober commented Jun 14, 2022

Got released with [email protected]

@janober janober removed the Upcoming Release Will be part of the upcoming release label Jun 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
community Authored by a community member node/improvement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants