Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🐛 Fix issue when saving long credential's types #2961

Merged
merged 3 commits into from
Mar 13, 2022
Merged

🐛 Fix issue when saving long credential's types #2961

merged 3 commits into from
Mar 13, 2022

Conversation

RicardoE105
Copy link
Contributor

@RicardoE105 RicardoE105 commented Mar 9, 2022 •
edited by janober
Loading

@RicardoE105 RicardoE105 changed the title 🐛 FIx issue when saving long credential's types 🐛 Fix issue when saving long credential's types Mar 9, 2022
@RicardoE105
🐛 Fix issue when saving long credential's types
ffc4de9 
The column type in the entity credentials was varchar(33) but nodes like Google Cloud Natural Language exceed the type length. The issue in only found when using Postgres. Mysql works fine as the column type has the proper length. Probably a migration at some point did not property update the column.

https://community.n8n.io/t/google-cloud-natural-language-credentials-error-too-long-value/12003/4
@Joffcom Joffcom added core Enhancement outside /nodes-base and /editor-ui n8n team Authored by the n8n team labels Mar 10, 2022
BHesseldieck
BHesseldieck suggested changes Mar 10, 2022
View reviewed changes
Copy link
Contributor

@BHesseldieck BHesseldieck left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for taking this!

some points we need to add:

  • adjust the length property in the CredentialsEntity, maybe even add validation as done for name
  • adjust the initial migration for sqlite for completeness (sqlite doesn't enforce length constraints)

@janober janober merged commit 535dfe0 into master Mar 13, 2022
@janober janober deleted the fix/postgres branch March 13, 2022 09:47
@janober janober added the Upcoming Release Will be part of the upcoming release label Mar 13, 2022
@janober
Copy link
Member

janober commented Mar 13, 2022

Thanks a lot. Got merged.

@janober
Copy link
Member

janober commented Mar 13, 2022

Got released with [email protected]

@janober janober removed the Upcoming Release Will be part of the upcoming release label Mar 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BHesseldieck BHesseldieck BHesseldieck requested changes

Assignees
No one assigned
Labels
core Enhancement outside /nodes-base and /editor-ui n8n team Authored by the n8n team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@RicardoE105 @janober @BHesseldieck @Joffcom