Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(editor): Load node types in demo and preview modes #12048

Merged
merged 2 commits into from
Dec 4, 2024

Conversation

alexgrozav
Copy link
Member

@alexgrozav alexgrozav commented Dec 4, 2024

Summary

Fixes issue causing node types not to load on new canvas preview and demo mode.

image

Related Linear tickets, Github issues, and Community forum posts

N/A

Review / Merge checklist

  • PR title and summary are descriptive. (conventions)
  • Docs updated or follow-up ticket created.
  • Tests included.
  • PR Labeled with release/backport (if the PR is an urgent fix that needs to be backported)

mutdmour
mutdmour previously approved these changes Dec 4, 2024
@n8n-assistant n8n-assistant bot added n8n team Authored by the n8n team ui Enhancement in /editor-ui or /design-system labels Dec 4, 2024
@netroy netroy added the release/backport Changes that need to be backported to older releases. label Dec 4, 2024
Copy link

cypress bot commented Dec 4, 2024

n8n    Run #8211

Run Properties:  status check passed Passed #8211  •  git commit 2d6aa21fa7: 🌳 🖥️ browsers:node18.12.0-chrome107 🤖 alexgrozav 🗃️ e2e/*
Project n8n
Branch Review fix-demo-nodetypes
Run status status check passed Passed #8211
Run duration 04m 43s
Commit git commit 2d6aa21fa7: 🌳 🖥️ browsers:node18.12.0-chrome107 🤖 alexgrozav 🗃️ e2e/*
Committer कारतोफ्फेलस्क्रिप्ट™
View all properties for this run ↗︎

Test results
Tests that failed  Failures 0
Tests that were flaky  Flaky 0
Tests that did not run due to a developer annotating a test with .skip  Pending 0
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 480
View all changes introduced in this branch ↗︎

Copy link
Contributor

github-actions bot commented Dec 4, 2024

✅ All Cypress E2E specs passed

Copy link

codecov bot commented Dec 4, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

📢 Thoughts on this report? Let us know!

@alexgrozav alexgrozav merged commit 4ac5f95 into master Dec 4, 2024
37 of 38 checks passed
@alexgrozav alexgrozav deleted the fix-demo-nodetypes branch December 4, 2024 16:43
ivov pushed a commit that referenced this pull request Dec 5, 2024
Co-authored-by: कारतोफ्फेलस्क्रिप्ट™ <[email protected]>
@github-actions github-actions bot mentioned this pull request Dec 5, 2024
@janober
Copy link
Member

janober commented Dec 5, 2024

Got released with [email protected]

ivov pushed a commit that referenced this pull request Dec 6, 2024
Co-authored-by: कारतोफ्फेलस्क्रिप्ट™ <[email protected]>
This was referenced Dec 6, 2024
riascho pushed a commit that referenced this pull request Jan 14, 2025
Co-authored-by: कारतोफ्फेलस्क्रिप्ट™ <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
n8n team Authored by the n8n team release/backport Changes that need to be backported to older releases. Released ui Enhancement in /editor-ui or /design-system
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants