fix(core): Opt-out from optimizations if $item is used
#12036
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ivov
approved these changes
Dec 4, 2024
| @@ -17,7 +17,7 @@ describe('BuiltInsParser', () => { | |||
| const parseAndExpectOk = (code: string) => { | |||
| const result = parser.parseUsedBuiltIns(code); | |||
| if (!result.ok) { | |||
| fail(result.error); | |||
| throw result.error; | |||
There was a problem hiding this comment.
Now parseAndExpectOk should be parseAndThrowOnError or parseOrThrow?
There was a problem hiding this comment.
I changed it because fail was not defined in jest runtime. The semantics are the same, it expects that that parsing succeeds. Now it just throws directly instead of using a function to throw
Codecov ReportAll modified and coverable lines are covered by tests ✅ 📢 Thoughts on this report? Let us know! |
Merged
|
Got released with |
tomi
added
the
release/backport
ivov
pushed a commit
that referenced
this pull request
Dec 4, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
$itemis legacy syntax in the Code Node and should not be used. We still need to support it. Opt-out from any optimizations in this case so we have correct data available.Related Linear tickets, Github issues, and Community forum posts
https://linear.app/n8n/issue/CAT-396/referenced-node-is-unexecuted-[item-0]-error
Review / Merge checklist
release/backport(if the PR is an urgent fix that needs to be backported)