Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(n8n Form Node): Duplicate popup in manual mode #11925

Merged

Conversation

michael-radency
Copy link
Contributor

Summary

duplicate popup in manual mode

Related Linear tickets, Github issues, and Community forum posts

https://linear.app/n8n/issue/NODE-2026/community-issue-n8n-form-node-freezes-when-clicking-next

Copy link
Member

@netroy netroy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

maybe we can do something like this instead a3958da

@n8n-assistant n8n-assistant bot added n8n team Authored by the n8n team ui Enhancement in /editor-ui or /design-system labels Nov 27, 2024
Copy link

cypress bot commented Nov 27, 2024

n8n    Run #8129

Run Properties:  status check passed Passed #8129  •  git commit 4d372f0273: 🌳 🖥️ browsers:node18.12.0-chrome107 🤖 michael-radency 🗃️ e2e/*
Project n8n
Branch Review node-2026-community-issue-n8n-form-node-double-pop-up-fix
Run status status check passed Passed #8129
Run duration 04m 41s
Commit git commit 4d372f0273: 🌳 🖥️ browsers:node18.12.0-chrome107 🤖 michael-radency 🗃️ e2e/*
Committer Michael Kret
View all properties for this run ↗︎

Test results
Tests that failed  Failures 0
Tests that were flaky  Flaky 1
Tests that did not run due to a developer annotating a test with .skip  Pending 0
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 478
View all changes introduced in this branch ↗︎

Copy link
Contributor

✅ All Cypress E2E specs passed

Copy link

codecov bot commented Nov 27, 2024

Codecov Report

Attention: Patch coverage is 23.52941% with 13 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
packages/editor-ui/src/utils/executionUtils.ts 21.42% 11 Missing ⚠️
packages/editor-ui/src/stores/workflows.store.ts 33.33% 2 Missing ⚠️

📢 Thoughts on this report? Let us know!

@netroy netroy merged commit 2c34bf4 into master Nov 27, 2024
35 checks passed
@netroy netroy deleted the node-2026-community-issue-n8n-form-node-double-pop-up-fix branch November 27, 2024 13:19
@github-actions github-actions bot mentioned this pull request Nov 27, 2024
@janober
Copy link
Member

janober commented Nov 27, 2024

Got released with [email protected]

despairblue pushed a commit that referenced this pull request Nov 28, 2024
Co-authored-by: कारतोफ्फेलस्क्रिप्ट™ <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
n8n team Authored by the n8n team Released ui Enhancement in /editor-ui or /design-system
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants