Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(editor): Migrate existing users to new canvas and set new canvas as default #11896

Merged
merged 5 commits into from
Nov 27, 2024

Conversation

alexgrozav
Copy link
Member

@alexgrozav alexgrozav commented Nov 26, 2024

Summary

  • new users land on canvas v2 automatically
  • old users get migrated to v2 automatically ONCE. If they switch back they stay on the old version
  • both old and new users see the tooltip below for the first time
Screen.Recording.2024-11-26.at.14.33.30.mov

Related Linear tickets, Github issues, and Community forum posts

https://linear.app/n8n/issue/N8N-7910/prepare-canvas-v2-for-open-beta
https://linear.app/n8n/issue/CAT-338/bug-new-canvas-callout-tooltip-not-correct-position-now

Review / Merge checklist

  • PR title and summary are descriptive. (conventions)
  • Docs updated or follow-up ticket created.
  • Tests included.
  • PR Labeled with release/backport (if the PR is an urgent fix that needs to be backported)

@alexgrozav alexgrozav self-assigned this Nov 26, 2024
@n8n-assistant n8n-assistant bot added n8n team Authored by the n8n team ui Enhancement in /editor-ui or /design-system labels Nov 26, 2024
Copy link

codecov bot commented Nov 26, 2024

Codecov Report

Attention: Patch coverage is 85.71429% with 5 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
...r-ui/src/components/MainHeader/WorkflowDetails.vue 58.33% 5 Missing ⚠️

📢 Thoughts on this report? Let us know!

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this change is great but i think it would be better to do it in a separate PR

r00gm
r00gm previously approved these changes Nov 26, 2024
Copy link
Contributor

⚠️ Some Cypress E2E specs are failing, please fix them before merging

Copy link

cypress bot commented Nov 26, 2024

n8n    Run #8109

Run Properties:  status check passed Passed #8109  •  git commit 815d848d08: 🌳 🖥️ browsers:node18.12.0-chrome107 🤖 alexgrozav 🗃️ e2e/*
Project n8n
Branch Review n8n-7910-prepare-canvas-v2-for-open-beta
Run status status check passed Passed #8109
Run duration 04m 39s
Commit git commit 815d848d08: 🌳 🖥️ browsers:node18.12.0-chrome107 🤖 alexgrozav 🗃️ e2e/*
Committer Alex Grozav
View all properties for this run ↗︎

Test results
Tests that failed  Failures 0
Tests that were flaky  Flaky 1
Tests that did not run due to a developer annotating a test with .skip  Pending 0
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 478
View all changes introduced in this branch ↗︎

cstuncsik
cstuncsik previously approved these changes Nov 26, 2024
Copy link
Contributor

⚠️ Some Cypress E2E specs are failing, please fix them before merging

2 similar comments
Copy link
Contributor

⚠️ Some Cypress E2E specs are failing, please fix them before merging

Copy link
Contributor

⚠️ Some Cypress E2E specs are failing, please fix them before merging

Copy link
Contributor

✅ All Cypress E2E specs passed

@alexgrozav alexgrozav merged commit caa7447 into master Nov 27, 2024
36 checks passed
@alexgrozav alexgrozav deleted the n8n-7910-prepare-canvas-v2-for-open-beta branch November 27, 2024 08:11
@github-actions github-actions bot mentioned this pull request Nov 27, 2024
@janober
Copy link
Member

janober commented Nov 27, 2024

Got released with [email protected]

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
n8n team Authored by the n8n team Released ui Enhancement in /editor-ui or /design-system
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants