Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(editor): Fix node position not getting set when dragging selection on new canvas #11871

Merged

Conversation

alexgrozav
Copy link
Member

@alexgrozav alexgrozav commented Nov 25, 2024

Summary

Screen.Recording.2024-11-25.at.14.34.12.mov

Related Linear tickets, Github issues, and Community forum posts

https://linear.app/n8n/issue/CAT-356/executing-a-workflow-manually-rearranges-nodes

Review / Merge checklist

  • PR title and summary are descriptive. (conventions)
  • Docs updated or follow-up ticket created.
  • Tests included.
  • PR Labeled with release/backport (if the PR is an urgent fix that needs to be backported)

@alexgrozav alexgrozav self-assigned this Nov 25, 2024
@n8n-assistant n8n-assistant bot added n8n team Authored by the n8n team ui Enhancement in /editor-ui or /design-system labels Nov 25, 2024
Copy link

codecov bot commented Nov 25, 2024

Codecov Report

Attention: Patch coverage is 25.00000% with 3 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
...ackages/editor-ui/src/components/canvas/Canvas.vue 25.00% 3 Missing ⚠️

📢 Thoughts on this report? Let us know!

Copy link
Contributor

✅ All Cypress E2E specs passed

Copy link

cypress bot commented Nov 25, 2024

n8n    Run #8078

Run Properties:  status check passed Passed #8078  •  git commit 595de81c03: 🌳 master 🖥️ browsers:node18.12.0-chrome107 🤖 PR User 🗃️ e2e/*
Project n8n
Branch Review master
Run status status check passed Passed #8078
Run duration 04m 40s
Commit git commit 595de81c03: 🌳 master 🖥️ browsers:node18.12.0-chrome107 🤖 PR User 🗃️ e2e/*
Committer Alex Grozav
View all properties for this run ↗︎

Test results
Tests that failed  Failures 0
Tests that were flaky  Flaky 0
Tests that did not run due to a developer annotating a test with .skip  Pending 0
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 478
View all changes introduced in this branch ↗︎

@alexgrozav alexgrozav merged commit 595de81 into master Nov 25, 2024
36 checks passed
@alexgrozav alexgrozav deleted the cat-356-executing-a-workflow-manually-rearranges-nodes branch November 25, 2024 13:29
@github-actions github-actions bot mentioned this pull request Nov 27, 2024
@janober
Copy link
Member

janober commented Nov 27, 2024

Got released with [email protected]

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
n8n team Authored by the n8n team Released ui Enhancement in /editor-ui or /design-system
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants