Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(n8n Form Node): Redirect if completion page to trigger #11822

Merged
merged 1 commit into from
Nov 21, 2024
Merged

fix(n8n Form Node): Redirect if completion page to trigger #11822

merged 1 commit into from
Nov 21, 2024

Conversation

michael-radency
Copy link
Contributor

Summary

fix for redirection not working if completion page connected to form trigger

Related Linear tickets, Github issues, and Community forum posts

https://linear.app/n8n/issue/NODE-2001/community-issue-n8n-form-redirect-url-is-not-working
Close #11657

@michael-radency michael-radency added n8n team Authored by the n8n team node/issue Issue with a node labels Nov 21, 2024
@codecov Codecov
Copy link

codecov bot commented Nov 21, 2024

Codecov Report

Attention: Patch coverage is 0% with 1 line in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
packages/nodes-base/nodes/Form/Form.node.ts 0.00% 1 Missing ⚠️

📢 Thoughts on this report? Let us know!

ShireenMissi
ShireenMissi approved these changes Nov 21, 2024
View reviewed changes
Copy link
Contributor

@ShireenMissi ShireenMissi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🎉

@ShireenMissi ShireenMissi added the tests-needed This PR needs additional tests label Nov 21, 2024
@cypress Cypress
Copy link

cypress bot commented Nov 21, 2024

n8n    Run #8036

Run Properties:  status check passed Passed #8036  •  git commit bc9aade412: 🌳 🖥️ browsers:node18.12.0-chrome107 🤖 michael-radency 🗃️ e2e/*
Project n8n
Branch Review node-2001-community-issue-n8n-form-redirect-url-is-not-working
Run status status check passed Passed #8036
Run duration 04m 40s
Commit git commit bc9aade412: 🌳 🖥️ browsers:node18.12.0-chrome107 🤖 michael-radency 🗃️ e2e/*
Committer Michael Kret
View all properties for this run ↗︎
Test results
Tests that failed  Failures 0
Tests that were flaky  Flaky 1
Tests that did not run due to a developer annotating a test with .skip  Pending 0
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 478
View all changes introduced in this branch ↗︎

@github-actions GitHub Actions
Copy link
Contributor

✅ All Cypress E2E specs passed

@ShireenMissi ShireenMissi merged commit 1a8fb7b into master Nov 21, 2024
35 checks passed
@ShireenMissi ShireenMissi deleted the node-2001-community-issue-n8n-form-redirect-url-is-not-working branch November 21, 2024 15:41
@github-actions github-actions bot mentioned this pull request Nov 27, 2024
Merged
@janober
Copy link
Member

janober commented Nov 27, 2024

Got released with [email protected]

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ShireenMissi ShireenMissi ShireenMissi approved these changes

Assignees
No one assigned
Labels
n8n team Authored by the n8n team node/issue Issue with a node Released tests-needed This PR needs additional tests
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

n8n Form redirect URL is not working
3 participants
@michael-radency @janober @ShireenMissi