feat(Slack Node): Update wait for approval to use markdown #11754
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
n8n-assistant
bot
added
n8n team
Codecov ReportAll modified and coverable lines are covered by tests ✅ 📢 Thoughts on this report? Let us know! |
|
|
n8n
|
||||||||||||||||||||||||||||
| Project |
n8n
|
| Branch Review |
master
|
| Run status |
|
| Run duration | 04m 29s |
| Commit |
|
| Committer | Jon |
| View all properties for this run ↗︎ | |
| Test results | |
|---|---|
Failures
|
0
|
Flaky
|
1
|
Pending
|
0
|
Skipped
|
0
|
Passing
|
478
|
| View all changes introduced in this branch ↗︎ | |
ShireenMissi
approved these changes
Nov 20, 2024
|
|
ShireenMissi
force-pushed
the
node-2036-slack-human-in-the-loop-support-markdown
branch
from
98ecf22 to
cead427
Compare
ShireenMissi
approved these changes
Nov 20, 2024
|
|
|
✅ All Cypress E2E specs passed |
ShireenMissi
deleted the
node-2036-slack-human-in-the-loop-support-markdown
branch
Merged
|
Got released with |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This adds a new version for the Slack node that uses Markdown only for the approval message, This also supports plain text and emojis so there shouldn't be any need to support plain text at all.
Related Linear tickets, Github issues, and Community forum posts
https://linear.app/n8n/issue/NODE-2036/slack-human-in-the-loop-support-markdown
Review / Merge checklist
release/backport(if the PR is an urgent fix that needs to be backported)