Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(editor): Fix hiding SQL query output when trying to select #11649

Conversation

elsmr
Copy link
Member

@elsmr elsmr commented Nov 8, 2024

Summary

Fix hiding SQL query output when trying to select

Related Linear tickets, Github issues, and Community forum posts

https://linear.app/n8n/issue/NODE-1812/sql-editor-popunder-closes-when-you-click-on-it-making-selecting-text
fixes #11603

Review / Merge checklist

  • PR title and summary are descriptive. (conventions)
  • Docs updated or follow-up ticket created.
  • Tests included.
  • PR Labeled with release/backport (if the PR is an urgent fix that needs to be backported)

@n8n-assistant n8n-assistant bot added n8n team Authored by the n8n team ui Enhancement in /editor-ui or /design-system labels Nov 8, 2024
Copy link

codecov bot commented Nov 8, 2024

Codecov Report

Attention: Patch coverage is 81.81818% with 4 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
...s/editor-ui/src/components/SqlEditor/SqlEditor.vue 81.81% 4 Missing ⚠️

📢 Thoughts on this report? Let us know!

Copy link
Contributor

@ShireenMissi ShireenMissi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🎉

Copy link

cypress bot commented Nov 11, 2024

n8n    Run #7817

Run Properties:  status check passed Passed #7817  •  git commit 00ad7a9446: 🌳 🖥️ browsers:node18.12.0-chrome107 🤖 elsmr 🗃️ e2e/*
Project n8n
Branch Review node-1812-sql-editor-popunder-closes-when-you-click-on-it-making
Run status status check passed Passed #7817
Run duration 04m 36s
Commit git commit 00ad7a9446: 🌳 🖥️ browsers:node18.12.0-chrome107 🤖 elsmr 🗃️ e2e/*
Committer Elias Meire
View all properties for this run ↗︎

Test results
Tests that failed  Failures 0
Tests that were flaky  Flaky 2
Tests that did not run due to a developer annotating a test with .skip  Pending 2
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 466
View all changes introduced in this branch ↗︎

Copy link
Contributor

✅ All Cypress E2E specs passed

@ShireenMissi ShireenMissi merged commit 4dbf2f4 into master Nov 11, 2024
35 checks passed
@ShireenMissi ShireenMissi deleted the node-1812-sql-editor-popunder-closes-when-you-click-on-it-making branch November 11, 2024 17:14
@github-actions github-actions bot mentioned this pull request Nov 13, 2024
@janober
Copy link
Member

janober commented Nov 13, 2024

Got released with [email protected]

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
n8n team Authored by the n8n team Released ui Enhancement in /editor-ui or /design-system
Projects
None yet
Development

Successfully merging this pull request may close these issues.

In Microsoft SQL Node can't copy query result preview
3 participants