Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(Oura Node): Update node for v2 api #11604

Merged
merged 2 commits into from
Nov 7, 2024
Merged

feat(Oura Node): Update node for v2 api #11604

merged 2 commits into from
Nov 7, 2024

Conversation

Joffcom
Copy link
Member

@Joffcom Joffcom commented Nov 6, 2024

Summary

Oura stopped using the v1 API a while back, This updates the node to use the v2 API. If it wasn't for the v1 API being removed already this normally would be a breaking change.

To test the API you need access to an Oura device which I don't currently have but maybe we can ask a user with a device to confirm. I did add a quick test and based on the API response it looks like it should work.

Related Linear tickets, Github issues, and Community forum posts

https://linear.app/n8n/issue/NODE-1954/community-issue-oura-node-uses-removed-v1-api
#11510

Review / Merge checklist

  • PR title and summary are descriptive. (conventions)
  • Docs updated or follow-up ticket created.
  • Tests included.
  • PR Labeled with release/backport (if the PR is an urgent fix that needs to be backported)

@Joffcom Joffcom changed the title Node 1954 feat(Oura Node): Update node for v2 api Nov 6, 2024
@n8n-assistant n8n-assistant bot added n8n team Authored by the n8n team node/improvement New feature or request labels Nov 6, 2024
Copy link

codecov bot commented Nov 6, 2024

Codecov Report

Attention: Patch coverage is 27.27273% with 32 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
packages/nodes-base/nodes/Oura/Oura.node.ts 17.94% 31 Missing and 1 partial ⚠️

📢 Thoughts on this report? Let us know!

Copy link
Contributor

@ShireenMissi ShireenMissi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🎉

Copy link

cypress bot commented Nov 7, 2024

n8n    Run #7767

Run Properties:  status check passed Passed #7767  •  git commit 9f8218c8be: 🌳 🖥️ browsers:node18.12.0-chrome107 🤖 Joffcom 🗃️ e2e/*
Project n8n
Branch Review node-1954
Run status status check passed Passed #7767
Run duration 04m 21s
Commit git commit 9f8218c8be: 🌳 🖥️ browsers:node18.12.0-chrome107 🤖 Joffcom 🗃️ e2e/*
Committer Jonathan Bennetts
View all properties for this run ↗︎

Test results
Tests that failed  Failures 0
Tests that were flaky  Flaky 2
Tests that did not run due to a developer annotating a test with .skip  Pending 2
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 462
View all changes introduced in this branch ↗︎

Copy link
Contributor

github-actions bot commented Nov 7, 2024

✅ All Cypress E2E specs passed

@ShireenMissi ShireenMissi merged commit 3348fbb into master Nov 7, 2024
35 of 36 checks passed
@ShireenMissi ShireenMissi deleted the node-1954 branch November 7, 2024 11:53
@github-actions github-actions bot mentioned this pull request Nov 13, 2024
@janober
Copy link
Member

janober commented Nov 13, 2024

Got released with [email protected]

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
n8n team Authored by the n8n team node/improvement New feature or request Released
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants