Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(AI Transform Node): Show warning for binary data #11560

Merged
merged 1 commit into from
Nov 7, 2024

Conversation

michael-radency
Copy link
Contributor

Summary

warning if binary data present in input

Related Linear tickets, Github issues, and Community forum posts

https://linear.app/n8n/issue/NODE-1865/show-warning-for-binary-data

@michael-radency michael-radency added node/improvement New feature or request n8n team Authored by the n8n team labels Nov 5, 2024
Copy link

codecov bot commented Nov 5, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

📢 Thoughts on this report? Let us know!

Copy link
Contributor

@ShireenMissi ShireenMissi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🎉

Copy link
Contributor

github-actions bot commented Nov 7, 2024

✅ All Cypress E2E specs passed

Copy link

cypress bot commented Nov 7, 2024

n8n    Run #7770

Run Properties:  status check passed Passed #7770  •  git commit f45f880284: 🌳 🖥️ browsers:node18.12.0-chrome107 🤖 michael-radency 🗃️ e2e/*
Project n8n
Branch Review node-1865-show-warning-for-binary-data
Run status status check passed Passed #7770
Run duration 04m 20s
Commit git commit f45f880284: 🌳 🖥️ browsers:node18.12.0-chrome107 🤖 michael-radency 🗃️ e2e/*
Committer Michael Kret
View all properties for this run ↗︎

Test results
Tests that failed  Failures 0
Tests that were flaky  Flaky 0
Tests that did not run due to a developer annotating a test with .skip  Pending 2
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 459
View all changes introduced in this branch ↗︎

@ShireenMissi ShireenMissi merged commit ddbb263 into master Nov 7, 2024
35 checks passed
@ShireenMissi ShireenMissi deleted the node-1865-show-warning-for-binary-data branch November 7, 2024 12:42
@github-actions github-actions bot mentioned this pull request Nov 13, 2024
@janober
Copy link
Member

janober commented Nov 13, 2024

Got released with [email protected]

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
n8n team Authored by the n8n team node/improvement New feature or request Released
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants