Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(Convert to File Node): Add delimiter convert to csv #11556

Merged
merged 1 commit into from
Nov 5, 2024

Conversation

Joffcom
Copy link
Member

@Joffcom Joffcom commented Nov 5, 2024

Summary

Adds delimiter option for writing to CSV, Updated workflow tests to use the new option

Related Linear tickets, Github issues, and Community forum posts

https://community.n8n.io/t/csv-spreadsheets-with-delimiter/27358
https://n8n-support.zammad.com/#ticket/zoom/8399
https://linear.app/n8n/issue/NODE-1971/convert-to-file-add-field-separator

Review / Merge checklist

  • PR title and summary are descriptive. (conventions)
  • Docs updated or follow-up ticket created.
  • Tests included.
  • PR Labeled with release/backport (if the PR is an urgent fix that needs to be backported)

@netroy netroy self-requested a review November 5, 2024 11:00
@n8n-assistant n8n-assistant bot added n8n team Authored by the n8n team node/improvement New feature or request labels Nov 5, 2024
Copy link

codecov bot commented Nov 5, 2024

Codecov Report

Attention: Patch coverage is 50.00000% with 1 line in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
packages/nodes-base/utils/binary.ts 50.00% 0 Missing and 1 partial ⚠️

📢 Thoughts on this report? Let us know!

@netroy netroy force-pushed the node-1971-convert-to-file-add-field-separator branch from ff1c183 to ba50588 Compare November 5, 2024 11:46
Copy link

cypress bot commented Nov 5, 2024

n8n    Run #7708

Run Properties:  status check passed Passed #7708  •  git commit ba5058882b: 🌳 🖥️ browsers:node18.12.0-chrome107 🤖 Joffcom 🗃️ e2e/*
Project n8n
Branch Review node-1971-convert-to-file-add-field-separator
Run status status check passed Passed #7708
Run duration 04m 20s
Commit git commit ba5058882b: 🌳 🖥️ browsers:node18.12.0-chrome107 🤖 Joffcom 🗃️ e2e/*
Committer Jonathan Bennetts
View all properties for this run ↗︎

Test results
Tests that failed  Failures 0
Tests that were flaky  Flaky 2
Tests that did not run due to a developer annotating a test with .skip  Pending 2
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 459
View all changes introduced in this branch ↗︎

Copy link
Contributor

github-actions bot commented Nov 5, 2024

✅ All Cypress E2E specs passed

@netroy netroy merged commit 63d454b into master Nov 5, 2024
33 checks passed
@netroy netroy deleted the node-1971-convert-to-file-add-field-separator branch November 5, 2024 12:17
This was referenced Nov 6, 2024
@janober
Copy link
Member

janober commented Nov 6, 2024

Got released with [email protected]

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
n8n team Authored by the n8n team node/improvement New feature or request Released
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants