Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(core): Use cached value in retrieval of personal project owner #11533

Merged
merged 4 commits into from
Nov 7, 2024
Merged

fix(core): Use cached value in retrieval of personal project owner #11533

merged 4 commits into from
Nov 7, 2024
+41 −21

Conversation

ivov
Copy link
Contributor

@ivov ivov commented Nov 4, 2024

@n8n-assistant n8n-assistant bot added core Enhancement outside /nodes-base and /editor-ui n8n team Authored by the n8n team labels Nov 4, 2024
@despairblue despairblue force-pushed the remove-assert-from-subworkflow-policy-checker branch from d2c17e1 to 35dd728 Compare November 4, 2024 16:14
@codecov Codecov
Copy link

codecov bot commented Nov 4, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

📢 Thoughts on this report? Let us know!

@ivov ivov changed the title fix(core): Remove assert from subworkflow policy checker fix(core): Use cached value in retrieval of personal project owner Nov 5, 2024
@cypress Cypress
Copy link

cypress bot commented Nov 7, 2024

n8n    Run #7760

Run Properties:  status check passed Passed #7760  •  git commit 4c0a0a5f56: 🌳 🖥️ browsers:node18.12.0-chrome107 🤖 ivov 🗃️ e2e/*
Project n8n
Branch Review remove-assert-from-subworkflow-policy-checker
Run status status check passed Passed #7760
Run duration 04m 22s
Commit git commit 4c0a0a5f56: 🌳 🖥️ browsers:node18.12.0-chrome107 🤖 ivov 🗃️ e2e/*
Committer Danny Martini
View all properties for this run ↗︎
Test results
Tests that failed  Failures 0
Tests that were flaky  Flaky 1
Tests that did not run due to a developer annotating a test with .skip  Pending 0
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 461
View all changes introduced in this branch ↗︎

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Nov 7, 2024

✅ All Cypress E2E specs passed

@ivov ivov merged commit 04029d8 into master Nov 7, 2024
35 checks passed
@ivov ivov deleted the remove-assert-from-subworkflow-policy-checker branch November 7, 2024 12:30
OlegIvaniv pushed a commit that referenced this pull request Nov 12, 2024
@ivov @despairblue @OlegIvaniv
fix(core): Use cached value in retrieval of personal project owner (#…
2ef0e72 
…11533)

Co-authored-by: Danny Martini <[email protected]>
@github-actions github-actions bot mentioned this pull request Nov 13, 2024
Merged
@janober
Copy link
Member

janober commented Nov 13, 2024

Got released with [email protected]

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@despairblue despairblue despairblue approved these changes

Assignees
No one assigned
Labels
core Enhancement outside /nodes-base and /editor-ui n8n team Authored by the n8n team Released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ivov @janober @despairblue