fix(core): Use the correct docs URL for regular nodes when used as tools #11529
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
n8n-assistant
bot
added
core
jeanpaul
previously approved these changes
Nov 4, 2024
netroy
force-pushed
the
fix-tools-docs-url
branch
from
8feda32 to
427bad7
Compare
jeanpaul
approved these changes
Nov 4, 2024
|
✅ All Cypress E2E specs passed |
n8n
|
||||||||||||||||||||||||||||
| Project |
n8n
|
| Branch Review |
fix-tools-docs-url
|
| Run status |
|
| Run duration | 04m 25s |
| Commit |
|
| Committer | कारतोफ्फेलस्क्रिप्ट™ |
| View all properties for this run ↗︎ | |
| Test results | |
|---|---|
Failures
|
0
|
Flaky
|
0
|
Pending
|
0
|
Skipped
|
0
|
Passing
|
461
|
| View all changes introduced in this branch ↗︎ | |
|
Got released with |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
When we create tool pseudo-nodes, we currently discard the original codex in the cloned description. The codex object often contains the primary documentation url, that the frontend uses to render the docs link in NDV.
This PR ensures that
NodeHelpers.convertNodeToAiToolalso copies over the original codex, to render the same docs urls for the tool version of the node and the regular version.Related Linear tickets, Github issues, and Community forum posts
https://n8nio.slack.com/archives/C05NR911BDH/p1730714790548369?thread_ts=1730714790.548369&cid=C05NR911BDH
Review / Merge checklist
release/backport(if the PR is an urgent fix that needs to be backported)