Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(core): Ensure remove-triggers-and-pollers command is not debounced #11486

Merged
merged 2 commits into from
Oct 31, 2024
Merged

fix(core): Ensure remove-triggers-and-pollers command is not debounced #11486

merged 2 commits into from
Oct 31, 2024

Conversation

ivov
Copy link
Contributor

@ivov ivov commented Oct 31, 2024

@n8n-assistant n8n-assistant bot added core Enhancement outside /nodes-base and /editor-ui n8n team Authored by the n8n team labels Oct 31, 2024
@ivov
Copy link
Contributor Author

ivov commented Oct 31, 2024

Related: #11306

@ivov ivov changed the title fix(core): Ensure add-webhooks-triggers-and-pollers command is debounced fix(core): Ensure remove-triggers-and-pollers command is not debounced Oct 31, 2024
tomi
tomi approved these changes Oct 31, 2024
View reviewed changes
Copy link
Contributor

@tomi tomi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@cypress Cypress
Copy link

cypress bot commented Oct 31, 2024

n8n    Run #7630

Run Properties:  status check passed Passed #7630  •  git commit af35faebca: 🌳 🖥️ browsers:node18.12.0-chrome107 🤖 ivov 🗃️ e2e/*
Project n8n
Branch Review cat-287-workflow-switches-to-inactive-when-saving
Run status status check passed Passed #7630
Run duration 04m 29s
Commit git commit af35faebca: 🌳 🖥️ browsers:node18.12.0-chrome107 🤖 ivov 🗃️ e2e/*
Committer Iván Ovejero
View all properties for this run ↗︎
Test results
Tests that failed  Failures 0
Tests that were flaky  Flaky 0
Tests that did not run due to a developer annotating a test with .skip  Pending 0
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 460
View all changes introduced in this branch ↗︎

@github-actions GitHub Actions
Copy link
Contributor

✅ All Cypress E2E specs passed

@tomi tomi merged commit 529d4fc into master Oct 31, 2024
34 checks passed
@tomi tomi deleted the cat-287-workflow-switches-to-inactive-when-saving branch October 31, 2024 13:27
@github-actions github-actions bot mentioned this pull request Oct 31, 2024
Merged
@janober
Copy link
Member

janober commented Oct 31, 2024

Got released with [email protected]

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tomi tomi tomi approved these changes

Assignees
No one assigned
Labels
core Enhancement outside /nodes-base and /editor-ui n8n team Authored by the n8n team Released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ivov @janober @tomi