Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(n8n Form Node): Form Trigger does not wait in multi-form mode #11404

Conversation

michael-radency
Copy link
Contributor

Summary

Form Trigger does not wait in multi-form mode

Related Linear tickets, Github issues, and Community forum posts

https://linear.app/n8n/issue/NODE-1916/community-issue-form-trigger-does-not-wait-in-multi-form-mode#comment-ae61578c
#11393

@michael-radency michael-radency added n8n team Authored by the n8n team node/issue Issue with a node labels Oct 25, 2024
Copy link
Contributor

@ShireenMissi ShireenMissi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🎉

@ShireenMissi ShireenMissi added release/backport Changes that need to be backported to older releases. tests-needed This PR needs additional tests labels Oct 25, 2024
Copy link
Contributor

⚠️ Some Cypress E2E specs are failing, please fix them before merging

Copy link

cypress bot commented Oct 25, 2024

n8n    Run #7568

Run Properties:  status check passed Passed #7568  •  git commit 45345dc471: 🌳 🖥️ browsers:node18.12.0-chrome107 🤖 michael-radency 🗃️ e2e/*
Project n8n
Branch Review node-1916-community-issue-form-trigger-does-not-wait-in-multi-form
Run status status check passed Passed #7568
Run duration 04m 23s
Commit git commit 45345dc471: 🌳 🖥️ browsers:node18.12.0-chrome107 🤖 michael-radency 🗃️ e2e/*
Committer Michael Kret
View all properties for this run ↗︎

Test results
Tests that failed  Failures 0
Tests that were flaky  Flaky 3
Tests that did not run due to a developer annotating a test with .skip  Pending 0
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 458
View all changes introduced in this branch ↗︎

…community-issue-form-trigger-does-not-wait-in-multi-form
Copy link
Contributor

✅ All Cypress E2E specs passed

@ShireenMissi ShireenMissi merged commit 151f4dd into master Oct 25, 2024
33 checks passed
@ShireenMissi ShireenMissi deleted the node-1916-community-issue-form-trigger-does-not-wait-in-multi-form branch October 25, 2024 10:49
This was referenced Oct 28, 2024
@janober
Copy link
Member

janober commented Oct 29, 2024

Got released with [email protected]

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
n8n team Authored by the n8n team node/issue Issue with a node release/backport Changes that need to be backported to older releases. Released tests-needed This PR needs additional tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants