Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(editor): Fix TypeError: Cannot read properties of undefined (reading '0') #11399

Merged

Conversation

r00gm
Copy link
Contributor

@r00gm r00gm commented Oct 24, 2024

Summary

Fix type issue added tests

Related Linear tickets, Github issues, and Community forum posts

PAY-2047

Review / Merge checklist

  • PR title and summary are descriptive. (conventions)
  • Docs updated or follow-up ticket created.
  • Tests included.
  • PR Labeled with release/backport (if the PR is an urgent fix that needs to be backported)

@n8n-assistant n8n-assistant bot added n8n team Authored by the n8n team ui Enhancement in /editor-ui or /design-system labels Oct 24, 2024
Copy link
Contributor

⚠️ Some Cypress E2E specs are failing, please fix them before merging

Copy link

cypress bot commented Oct 24, 2024

n8n    Run #7586

Run Properties:  status check passed Passed #7586  •  git commit 33a93b2a24: 🌳 🖥️ browsers:node18.12.0-chrome107 🤖 r00gm 🗃️ e2e/*
Project n8n
Branch Review pay-2047-typeerror-cannot-read-properties-of-undefined-reading-0
Run status status check passed Passed #7586
Run duration 04m 20s
Commit git commit 33a93b2a24: 🌳 🖥️ browsers:node18.12.0-chrome107 🤖 r00gm 🗃️ e2e/*
Committer r00gm
View all properties for this run ↗︎

Test results
Tests that failed  Failures 0
Tests that were flaky  Flaky 0
Tests that did not run due to a developer annotating a test with .skip  Pending 0
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 459
View all changes introduced in this branch ↗︎

Copy link
Contributor

⚠️ Some Cypress E2E specs are failing, please fix them before merging

Copy link
Contributor

✅ All Cypress E2E specs passed

@r00gm r00gm merged commit ae37c52 into master Oct 28, 2024
32 of 33 checks passed
@r00gm r00gm deleted the pay-2047-typeerror-cannot-read-properties-of-undefined-reading-0 branch October 28, 2024 09:15
This was referenced Oct 28, 2024
@janober
Copy link
Member

janober commented Oct 31, 2024

Got released with [email protected]

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
n8n team Authored by the n8n team Released ui Enhancement in /editor-ui or /design-system
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants