fix(API): PUT /credentials/:id should move the specified credential, not the first one in the database
#11365
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…, not the first one in the database
valya
approved these changes
Oct 23, 2024
n8n-assistant
bot
added
core
|
|
n8n
|
||||||||||||||||||||||||||||
| Project |
n8n
|
| Branch Review |
fix-public-api-credential-move
|
| Run status |
|
| Run duration | 04m 19s |
| Commit |
|
| Committer | Danny Martini |
| View all properties for this run ↗︎ | |
| Test results | |
|---|---|
Failures
|
0
|
Flaky
|
3
|
Pending
|
0
|
Skipped
|
0
|
Passing
|
458
|
| View all changes introduced in this branch ↗︎ | |
|
✅ All Cypress E2E specs passed |
Merged
|
Got released with |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Before this using the public API to move a credential would ignore the credential id in the path, due to a type error, and move the first credential it finds in the database that the user has access to.
This PR fixes this by fixing the type error and adding a test.
Related Linear tickets, Github issues, and Community forum posts
Review / Merge checklist
Docs updated or follow-up ticket created.PR Labeled withrelease/backport(if the PR is an urgent fix that needs to be backported)