fix: Resend invite operation on users list #11351
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RicardoE105
changed the title
RicardoE105
changed the title
netroy
previously requested changes
Oct 22, 2024
n8n-assistant
bot
added
n8n team
despairblue
requested changes
Oct 22, 2024
Co-authored-by: Danny Martini <[email protected]>
|
@despairblue yes, adding the role there is an overlooked. Just committed your change. Adding the the ID and not returning the role still works. |
Would it be cleaner to add the |
This makes sure the role is in the user store in the frontend without the FE needing to do manual remapping.
|
@RicardoE105 this is what I mean: Just wondering if that is cleaner, than having the FE retain data it sends to the API and merge it with the response. |
|
@despairblue gotcha now. Yes, let's do that. Will include that change if this PR if you do not mind. |
…lt' into help-645-resend-invitation-link-does-not-work-anymore
RicardoE105
changed the title
despairblue
approved these changes
Oct 23, 2024
n8n
|
||||||||||||||||||||||||||||
| Project |
n8n
|
| Branch Review |
help-645-resend-invitation-link-does-not-work-anymore
|
| Run status |
|
| Run duration | 04m 27s |
| Commit |
|
| Committer | Ricardo Espinoza |
| View all properties for this run ↗︎ | |
| Test results | |
|---|---|
Failures
|
0
|
Flaky
|
3
|
Pending
|
0
|
Skipped
|
0
|
Passing
|
458
|
| View all changes introduced in this branch ↗︎ | |
|
✅ All Cypress E2E specs passed |
RicardoE105
deleted the
help-645-resend-invitation-link-does-not-work-anymore
branch
Merged
|
Got released with |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Pending users were added into the store with the property
globalRole, but when we return the users we save them in the store with the propertyroleinstead.Before
See video on ticket -> https://linear.app/n8n/issue/HELP-645/resend-invitation-link-does-not-work-anymore
Now
Related Linear tickets, Github issues, and Community forum posts
https://linear.app/n8n/issue/HELP-645/resend-invitation-link-does-not-work-anymore
Review / Merge checklist
release/backport(if the PR is an urgent fix that needs to be backported)