fix(core): Add safeguard for command publishing #11337
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Until we decouple command publishing from all the various services, e.g. via a relay, we should ensure that main mode is unable to publish commands. Context: https://n8nio.slack.com/archives/C069HS026UF/p1729526419136009
n8n-assistant
bot
added
core
netroy
requested changes
Oct 22, 2024
| @@ -46,6 +46,9 @@ export class Publisher { | |||
|
|
|||
| /** Publish a command into the `n8n.commands` channel. */ | |||
| async publishCommand(msg: Omit<PubSub.Command, 'senderId'>) { | |||
| // @TODO: Once this class is only ever used in scaling mode, remove next line. | |||
| if (config.getEnv('executions.mode') !== 'queue') return; | |||
There was a problem hiding this comment.
it feels like we are repeating this check. Since the execution mode can't change at runtime, could we not change await this.client.publish to await this.client?.publish instead ?
There was a problem hiding this comment.
Not a fan of either execution mode sanity checks or calling methods with an uninitialized client. This is only a temporary fix until we can decouple and dynamically load the Publisher as mentioned here.
netroy
approved these changes
Oct 23, 2024
|
|
n8n
|
||||||||||||||||||||||||||||
| Project |
n8n
|
| Branch Review |
safeguard-command-publishing
|
| Run status |
|
| Run duration | 04m 24s |
| Commit |
|
| Committer | Iván Ovejero |
| View all properties for this run ↗︎ | |
| Test results | |
|---|---|
Failures
|
0
|
Flaky
|
0
|
Pending
|
0
|
Skipped
|
0
|
Passing
|
458
|
| View all changes introduced in this branch ↗︎ | |
netroy
approved these changes
Oct 24, 2024
|
✅ All Cypress E2E specs passed |
|
Got released with |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Until we decouple command publishing from all the various services, e.g. via a relay, we should ensure that main mode is unable to publish commands.
Context: https://n8nio.slack.com/archives/C069HS026UF/p1729526419136009