fix(core): Fix memory issue with empty model response #11300
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
OlegIvaniv
approved these changes
Oct 22, 2024
n8n
|
||||||||||||||||||||||||||||
| Project |
n8n
|
| Branch Review |
ai-395-community-issue-ai-agent-output-after-execution-is-empty-i
|
| Run status |
|
| Run duration | 04m 20s |
| Commit |
|
| Committer | Eugene Molodkin |
| View all properties for this run ↗︎ | |
| Test results | |
|---|---|
Failures
|
0
|
Flaky
|
2
|
Pending
|
0
|
Skipped
|
0
|
Passing
|
453
|
| View all changes introduced in this branch ↗︎ | |
|
✅ All Cypress E2E specs passed |
burivuhster
deleted the
ai-395-community-issue-ai-agent-output-after-execution-is-empty-i
branch
|
hey when it's push to production ? |
Merged
|
Got released with |
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR addresses the issue with memory sub-nodes. In some cases model may respond with an empty string. LangChain's memory code throws an exception, while trying to save this to a message history, because it uses coercion to boolean.
The problematic line of code is here:
https://github.com/langchain-ai/langchainjs/blob/c9b80263a0777c39d5bdaa30728715c5e124f55e/langchain-core/src/memory.ts#L93
This affects all memory nodes.
The proper solution would be to fix this in the LangChain, but as a temporary fix we may just use a patch.
Related Linear tickets, Github issues, and Community forum posts
Review / Merge checklist
release/backport(if the PR is an urgent fix that needs to be backported)