-
Notifications
You must be signed in to change notification settings - Fork 7.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(editor): Open Community+ enrollment modal only for the instance owner #11292
Merged
cstuncsik
merged 8 commits into
master
from
pay-2115-only-show-community-opt-in-to-instance-owners
Oct 21, 2024
Merged
fix(editor): Open Community+ enrollment modal only for the instance owner #11292
cstuncsik
merged 8 commits into
master
from
pay-2115-only-show-community-opt-in-to-instance-owners
Oct 21, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
n8n-assistant
bot
added
n8n team
Authored by the n8n team
ui
Enhancement in /editor-ui or /design-system
labels
Oct 17, 2024
…community-opt-in-to-instance-owners
r00gm
approved these changes
Oct 18, 2024
✅ All Cypress E2E specs passed |
n8n Run #7427
Run Properties:
|
Project |
n8n
|
Run status |
Passed #7427
|
Run duration | 04m 21s |
Commit |
9027f17acc: 🌳 🖥️ browsers:node18.12.0-chrome107 🤖 cstuncsik 🗃️ e2e/*
|
Committer | Csaba Tuncsik |
View all properties for this run ↗︎ |
Test results | |
---|---|
Failures |
0
|
Flaky |
2
|
Pending |
0
|
Skipped |
0
|
Passing |
453
|
cstuncsik
deleted the
pay-2115-only-show-community-opt-in-to-instance-owners
branch
October 21, 2024 08:02
Merged
Got released with |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Currently, the Community register modal opens to any user role, but we want it to open only for the instance owner
Related Linear tickets, Github issues, and Community forum posts
PAY-2115
Review / Merge checklist
release/backport