Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(Google Ads Node): Update to use v17 api #11243

Merged
merged 1 commit into from
Oct 14, 2024

Conversation

Joffcom
Copy link
Member

@Joffcom Joffcom commented Oct 14, 2024

Summary

Updates Google Ads node to use the v17 api, API release notes show no breaking changes for the 2 calls we make

API Release Notes: https://developers.google.com/google-ads/api/docs/release-notes

Get Many Campaigns
image

Get One Campaign
image

Related Linear tickets, Github issues, and Community forum posts

https://linear.app/n8n/issue/NODE-1869/google-ads-update-api
https://n8n-support.zammad.com/#ticket/zoom/7902

Review / Merge checklist

  • PR title and summary are descriptive. (conventions)
  • Docs updated or follow-up ticket created.
  • Tests included.
  • PR Labeled with release/backport (if the PR is an urgent fix that needs to be backported)

@n8n-assistant n8n-assistant bot added n8n team Authored by the n8n team node/improvement New feature or request labels Oct 14, 2024
Copy link
Contributor

@ShireenMissi ShireenMissi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🎉

Copy link

cypress bot commented Oct 14, 2024

n8n    Run #7351

Run Properties:  status check passed Passed #7351  •  git commit bad254f454: 🌳 🖥️ browsers:node18.12.0-chrome107 🤖 Joffcom 🗃️ e2e/*
Project n8n
Run status status check passed Passed #7351
Run duration 04m 29s
Commit git commit bad254f454: 🌳 🖥️ browsers:node18.12.0-chrome107 🤖 Joffcom 🗃️ e2e/*
Committer Jonathan Bennetts
View all properties for this run ↗︎

Test results
Tests that failed  Failures 0
Tests that were flaky  Flaky 2
Tests that did not run due to a developer annotating a test with .skip  Pending 0
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 438

Copy link
Contributor

✅ All Cypress E2E specs passed

@ShireenMissi ShireenMissi merged commit 3d97f02 into master Oct 14, 2024
33 checks passed
@ShireenMissi ShireenMissi deleted the node-1869-google-ads-update-api branch October 14, 2024 13:13
@github-actions github-actions bot mentioned this pull request Oct 16, 2024
@janober
Copy link
Member

janober commented Oct 16, 2024

Got released with [email protected]

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
n8n team Authored by the n8n team node/improvement New feature or request Released
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants