perf(Google Sheets Node): Don't load whole spreadsheet dataset to determine columns when appending data #11235
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change reduces the amount of data that is been loaded when appending new rows to a google sheet. Before this change was the whole data set of the spreadsheet loaded, but only a few rows were needed to identity the columns. The issue is that the provided "range" parameter of the execute function only contains the sheet name without any range annotations. In case there would be any range annotations in the range, I extract the sheet name from it.
|
|
soerenuhrbach
commented
Oct 11, 2024
packages/nodes-base/nodes/Google/Sheet/v2/actions/sheet/append.operation.ts
Show resolved
Hide resolved
|
Loaded data before the change of this pull request: 
Loaded data after the change of this pull request has been applied: 
|
n8n-assistant
bot
added
community
|
Hey @soerenuhrbach, Thanks for the PR, We have created "GHC-311" as the internal reference to get this reviewed. One of us will be in touch if there are any changes needed, in most cases this is normally within a couple of weeks but it depends on the current workload of the team. |
michael-radency
approved these changes
Oct 15, 2024
Merged
|
Got released with |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This change reduces the amount of data that will be loaded to identify columns when appending new rows to a google sheet.
Explanation
Before this change was the whole data set of the spreadsheet loaded, but only a few rows were needed to identity the columns. The problem is that the provided "range" parameter of the execute function only contains the sheet name without any range annotations. In case there would be any range annotations in the range, I extract the sheet name from it.
Related Linear tickets, Github issues, and Community forum posts
Github issue #11234
Review / Merge checklist
release/backport(if the PR is an urgent fix that needs to be backported)