fix(Strava Trigger Node): Fix issue with webhook not being deleted #11226
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
n8n-assistant
bot
added
n8n team
elsmr
approved these changes
Oct 11, 2024
n8n
|
||||||||||||||||||||||||
| Project |
n8n
|
| Run status |
|
| Run duration | 04m 27s |
| Commit |
|
| Committer | Jonathan Bennetts |
| View all properties for this run ↗︎ | |
| Test results | |
|---|---|
Failures
|
0
|
Flaky
|
2
|
Pending
|
0
|
Skipped
|
0
|
Passing
|
439
|
|
✅ All Cypress E2E specs passed |
Joffcom
deleted the
node-1848-strava-trigger-node-unable-to-activate-the-trigger
branch
Merged
|
Got released with |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
We were not checking the correct error value or sending the id and secret as url params on a delete. We now show a more useful error message and we delete the webhook when we should.
Related Linear tickets, Github issues, and Community forum posts
https://linear.app/n8n/issue/NODE-1848/strava-trigger-node-unable-to-activate-the-trigger
https://community.n8n.io/t/bad-request-when-activating-strava-trigger-node/54306/3
https://community.n8n.io/t/strava-trigger-is-not-working/57201
Review / Merge checklist
release/backport(if the PR is an urgent fix that needs to be backported)