Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(editor): Fix sorting problem in older browsers that don't support toSorted #11204

Merged
merged 5 commits into from
Oct 17, 2024
Merged

fix(editor): Fix sorting problem in older browsers that don't support toSorted #11204

merged 5 commits into from
Oct 17, 2024

Conversation

cstuncsik
Copy link
Contributor

@cstuncsik cstuncsik commented Oct 10, 2024 •
edited
Loading

Summary

Remove toSorted array method usage to support older browsers

Related Linear tickets, Github issues, and Community forum posts

PAY-2045

Review / Merge checklist

  • PR title and summary are descriptive.
  • Tests included.
  • PR Labeled with release/backport

@n8n-assistant n8n-assistant bot added n8n team Authored by the n8n team ui Enhancement in /editor-ui or /design-system labels Oct 10, 2024
@cstuncsik cstuncsik requested a review from r00gm October 10, 2024 12:42
r00gm
r00gm reviewed Oct 17, 2024
View reviewed changes
packages/editor-ui/src/utils/sortUtils.test.ts
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

❤️

r00gm
r00gm approved these changes Oct 17, 2024
View reviewed changes
Copy link
Contributor

@r00gm r00gm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you so much for the newly added tests 🙏

@github-actions GitHub Actions
Copy link
Contributor

✅ All Cypress E2E specs passed

@cypress Cypress
Copy link

cypress bot commented Oct 17, 2024

n8n    Run #7406

Run Properties:  status check passed Passed #7406  •  git commit 46ce7966cf: 🌳 🖥️ browsers:node18.12.0-chrome107 🤖 cstuncsik 🗃️ e2e/*
Project n8n
Run status status check passed Passed #7406
Run duration 04m 24s
Commit git commit 46ce7966cf: 🌳 🖥️ browsers:node18.12.0-chrome107 🤖 cstuncsik 🗃️ e2e/*
Committer Csaba Tuncsik
View all properties for this run ↗︎
Test results
Tests that failed  Failures 0
Tests that were flaky  Flaky 1
Tests that did not run due to a developer annotating a test with .skip  Pending 0
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 453

@cstuncsik cstuncsik merged commit c728a2f into master Oct 17, 2024
42 checks passed
@cstuncsik cstuncsik deleted the pay-2045-typeerror-projectsstoremyprojectsfiltertosorted-is-not-a branch October 17, 2024 12:11
@github-actions github-actions bot mentioned this pull request Oct 24, 2024
Merged
@janober
Copy link
Member

janober commented Oct 24, 2024

Got released with [email protected]

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@r00gm r00gm r00gm approved these changes

Assignees
No one assigned
Labels
n8n team Authored by the n8n team Released ui Enhancement in /editor-ui or /design-system
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@cstuncsik @janober @r00gm