Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(editor): Fix pin data button disappearing after reload #11198

Merged
merged 8 commits into from
Oct 21, 2024
Merged

fix(editor): Fix pin data button disappearing after reload #11198

merged 8 commits into from
Oct 21, 2024

Conversation

MiloradFilipovic
Copy link
Contributor

Summary

  • Disabling pin data button when data is pinned:
Screen.Recording.2024-10-10.at.11.44.28.mov
  • Preventing the button from disappearing when page is reloaded:
Screen.Recording.2024-10-10.at.11.46.18.mov

Related Linear tickets, Github issues, and Community forum posts

Fixes ADO-2636

Review / Merge checklist

  • PR title and summary are descriptive. (conventions)
  • Docs updated or follow-up ticket created.
  • Tests included.
  • PR Labeled with release/backport (if the PR is an urgent fix that needs to be backported)

@MiloradFilipovic MiloradFilipovic self-assigned this Oct 10, 2024
@n8n-assistant n8n-assistant bot added n8n team Authored by the n8n team ui Enhancement in /editor-ui or /design-system labels Oct 10, 2024
fedme
fedme previously approved these changes Oct 10, 2024
View reviewed changes
Copy link
Contributor

@fedme fedme left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @MiloradFilipovic, the fix works well for me. Do you think we might want to add a test for it?

@github-actions GitHub Actions
Copy link
Contributor

⚠️ Some Cypress E2E specs are failing, please fix them before merging

@cypress Cypress
Copy link

cypress bot commented Oct 10, 2024 •
edited
Loading

n8n    Run #7440

Run Properties:  status check failed Failed #7440  •  git commit d884fc489c: 🌳 🖥️ browsers:node18.12.0-chrome107 🤖 MiloradFilipovic 🗃️ e2e/*
Project n8n
Run status status check failed Failed #7440
Run duration 04m 03s
Commit git commit d884fc489c: 🌳 🖥️ browsers:node18.12.0-chrome107 🤖 MiloradFilipovic 🗃️ e2e/*
Committer Milorad FIlipović
View all properties for this run ↗︎
Test results
Tests that failed  Failures 1
Tests that were flaky  Flaky 2
Tests that did not run due to a developer annotating a test with .skip  Pending 0
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 247

Tests for review

Failed  28-debug.cy.ts • 1 failed test

View Output Video

Test Artifacts
Debug > should be able to debug executions Test Replay Screenshots Video
Failed  45-ai-assistant.cy.ts • 0 failed tests

View Output

Test Artifacts
Failed  2-credentials.cy.ts • 0 failed tests

View Output

Test Artifacts
Failed  11-inline-expression-editor.cy.ts • 0 failed tests

View Output

Test Artifacts
Failed  30-editor-after-route-changes.cy.ts • 0 failed tests

View Output

Test Artifacts

The first 5 failed specs are shown, see all 47 specs in Cypress Cloud.

Flakiness  17-sharing.cy.ts • 1 flaky test

View Output Video

Test Artifacts
Sharing > credentials should work between team and personal projects Test Replay Screenshots Video
Flakiness  19-execution.cy.ts • 1 flaky test

View Output Video

Test Artifacts
Execution > should test webhook workflow stop Test Replay Screenshots Video

@github-actions GitHub Actions
Copy link
Contributor

⚠️ Some Cypress E2E specs are failing, please fix them before merging

fedme
fedme previously approved these changes Oct 11, 2024
View reviewed changes
@github-actions GitHub Actions
Copy link
Contributor

⚠️ Some Cypress E2E specs are failing, please fix them before merging

1 similar comment
@github-actions GitHub Actions
Copy link
Contributor

⚠️ Some Cypress E2E specs are failing, please fix them before merging

@github-actions GitHub Actions
Copy link
Contributor

⚠️ Some Cypress E2E specs are failing, please fix them before merging

1 similar comment
@github-actions GitHub Actions
Copy link
Contributor

⚠️ Some Cypress E2E specs are failing, please fix them before merging

@github-actions GitHub Actions
Copy link
Contributor

⚠️ Some Cypress E2E specs are failing, please fix them before merging

fedme
fedme previously approved these changes Oct 21, 2024
View reviewed changes
@github-actions GitHub Actions
Copy link
Contributor

⚠️ Some Cypress E2E specs are failing, please fix them before merging

@github-actions GitHub Actions
Copy link
Contributor

✅ All Cypress E2E specs passed

@MiloradFilipovic MiloradFilipovic merged commit 3b2f63e into master Oct 21, 2024
34 checks passed
@MiloradFilipovic MiloradFilipovic deleted the ADO-2636-fix-pin-data-button branch October 21, 2024 10:05
@github-actions github-actions bot mentioned this pull request Oct 24, 2024
Merged
@janober
Copy link
Member

janober commented Oct 24, 2024

Got released with [email protected]

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fedme fedme fedme approved these changes

Assignees

@MiloradFilipovic MiloradFilipovic

Labels
n8n team Authored by the n8n team Released ui Enhancement in /editor-ui or /design-system
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@MiloradFilipovic @janober @fedme