feat(core): Handle cycles in workflows when partially executing them #11187
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
n8n-assistant
bot
added
core
despairblue
force-pushed
the
pay-1757-phase-2-cycle-detection-and-handling-try-2
branch
2 times, most recently
from
af5b8b1
to
cae9693
Compare
despairblue
force-pushed
the
pay-1757-phase-2-cycle-detection-and-handling-try-2
branch
from
df0e688
to
2ad28a2
Compare
tomi
previously approved these changes
Oct 18, 2024
Comment on lines
121
to
123
| expect(stronglyConnectedComponents).toHaveLength(2); | ||
| expect(stronglyConnectedComponents).toContainEqual([node4]); | ||
| expect(stronglyConnectedComponents).toContainEqual([node3, node2, node1]); |
There was a problem hiding this comment.
Do we care about the order in which the connected components are returned? Should we instead check
Suggested change
| expect(stronglyConnectedComponents).toHaveLength(2); | |
| expect(stronglyConnectedComponents).toContainEqual([node4]); | |
| expect(stronglyConnectedComponents).toContainEqual([node3, node2, node1]); | |
| expect(stronglyConnectedComponents).toEqual([ | |
| [node4], | |
| [node3, node2, node1] | |
| ]) |
?
There was a problem hiding this comment.
I don't think we care about the order. It should be stable but it does not convey any information as far as I know, and as far as the use case is concerned.
So it's ok to leave it like this so that we don't have to touch the tests if we change the algorithm.
packages/core/src/PartialExecutionUtils/__tests__/DirectedGraph.test.ts
Outdated
Show resolved
Hide resolved
|
✅ All Cypress E2E specs passed |
n8n
|
||||||||||||||||||||||||
| Project |
n8n
|
| Run status |
|
| Run duration | 04m 16s |
| Commit |
|
| Committer | Danny Martini |
| View all properties for this run ↗︎ | |
| Test results | |
|---|---|
Failures
|
0
|
Flaky
|
1
|
Pending
|
0
|
Skipped
|
0
|
Passing
|
453
|
tomi
approved these changes
Oct 18, 2024
|
✅ All Cypress E2E specs passed |
despairblue
deleted the
pay-1757-phase-2-cycle-detection-and-handling-try-2
branch
Merged
4 tasks
Merged
|
Got released with |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This implement cycle handling according to the specification for the new partial execution flow.
Basically if a start node is inside a cycle the start of the cycle will become the start node.
This is to make it more predictable instead of figuring out if the loop has finished executing or not and thus deciding if the run data should be kept or invalidated. We just start cycles/loops always from the start.
You can review commit by commit.
Additionally this contains:
Related Linear tickets, Github issues, and Community forum posts
https://linear.app/n8n/issue/PAY-1757/phase-2-cycle-detection-and-handling
Review / Merge checklist
Docs updated or follow-up ticket created.PR Labeled withrelease/backport(if the PR is an urgent fix that needs to be backported)