feat(editor): Update ownership pills #11155
Conversation
n8n-assistant
bot
added
n8n team
…wcredential-cards-and
| const numberOfMembersInHomeTeamProject = computed( | ||
| () => props.resource.sharedWithProjects?.length ?? 0, | ||
| ); |
There was a problem hiding this comment.
@cstuncsik please double check this is the correct source of truth
There was a problem hiding this comment.
I'm not sure what the intention is here (maybe the variable name is confusing)
If we want to show how many users the resource is shared with, then it's correct.
If we want to show how many users are there in the home project of the resource, then it's not
If the latter you need to get the home project of the resource (by the homeProject.id) and check the length of its relations
There was a problem hiding this comment.
to the extend of my knowledge.. we want to share how many users the resource is shared with, i'll ask in the ticket to double check
There was a problem hiding this comment.
That's the easier, the other one could only be problematic in the Home project because the resources are listed from all available projects and you would need to get all the relations for all the projects
In a team project you just get it from the store (projectsStore.currentProject.relations)
…wcredential-cards-and
|
|
n8n
|
||||||||||||||||||||||||||||
| Project |
n8n
|
| Branch Review |
pay-1803-update-ownership-pills-on-workflowcredential-cards-and
|
| Run status |
|
| Run duration | 04m 25s |
| Commit |
|
| Committer | r00gm |
| View all properties for this run ↗︎ | |
| Test results | |
|---|---|
Failures
|
0
|
Flaky
|
3
|
Pending
|
0
|
Skipped
|
0
|
Passing
|
459
|
| View all changes introduced in this branch ↗︎ | |
|
|
1 similar comment
|
|
…wcredential-cards-and
|
|
|
|
…wcredential-cards-and
|
✅ All Cypress E2E specs passed |
r00gm
deleted the
pay-1803-update-ownership-pills-on-workflowcredential-cards-and
branch
|
Got released with |
Summary
Related Linear tickets, Github issues, and Community forum posts
PAY-1803
Review / Merge checklist
release/backport(if the PR is an urgent fix that needs to be backported)