feat(Structured Output Parser Node): Refactor Output Parsers and Improve Error Handling #11148
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…n-and-not-on-sub-node
…n-and-not-on-sub-node
n8n-assistant
bot
added
n8n team
OlegIvaniv
changed the title
burivuhster
reviewed
Oct 10, 2024
...angchain/nodes/output_parser/OutputParserAutofixing/test/OutputParserAutofixing.node.test.ts
Outdated
Show resolved
Hide resolved
burivuhster
requested changes
Oct 10, 2024
burivuhster
previously approved these changes
Oct 22, 2024
n8n
|
||||||||||||||||||||||||||||
| Project |
n8n
|
| Branch Review |
ai-362-output-parser-errors-appear-on-chain-and-not-on-sub-node
|
| Run status |
|
| Run duration | 04m 17s |
| Commit |
|
| Committer | Oleg Ivaniv |
| View all properties for this run ↗︎ | |
| Test results | |
|---|---|
Failures
|
0
|
Flaky
|
2
|
Pending
|
0
|
Skipped
|
0
|
Passing
|
458
|
| View all changes introduced in this branch ↗︎ | |
|
✅ All Cypress E2E specs passed |
burivuhster
approved these changes
Oct 22, 2024
|
✅ All Cypress E2E specs passed |
OlegIvaniv
deleted the
ai-362-output-parser-errors-appear-on-chain-and-not-on-sub-node
branch
Merged
|
Got released with |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR refactors our output parser implementation, extracting them into individual classes and improving error handling, particularly for structured output parsers. These changes should improve our ability to provide user-friendly error messages while maintaining the functionality of the auto-fixing parser.
N8nStructuredOutputParsernow includes acontextproperty to handle execution context and supports custom error mapping.N8nOutputFixingParserintegrates with the structured parser to attempt fixing invalid outputs.N8nItemListOutputParserretains its functionality but is now part of the new parser structure.getOptionalOutputParsersutility to work with the new parser types.Changes
Extracted output parsers into separate classes:
N8nStructuredOutputParserN8nOutputFixingParserN8nItemListOutputParserImplemented error mapping in
N8nStructuredOutputParserto allow for both user-friendly error messages and proper error handling in the auto-fixing parser.Removed proxy wrapping from
logWrapperand instead manually populate input/output data from each parser class.Updated relevant nodes and utility functions to use the new parser classes.
Adjusted test files to reflect the new structure and functionality and added tests for
N8nOutputFixingParserandN8nItemListOutputParsernodes.Related Linear tickets, Github issues, and Community forum posts
Review / Merge checklist
release/backport(if the PR is an urgent fix that needs to be backported)